Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 8866e34

Browse filesBrowse files
committed
Show that the dendrogram test should have failed!
1 parent ca08777 commit 8866e34
Copy full SHA for 8866e34

File tree

Expand file treeCollapse file tree

1 file changed

+13
-19
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+13
-19
lines changed

‎plotly/tests/test_optional/test_opt_tracefactory.py

Copy file name to clipboardExpand all lines: plotly/tests/test_optional/test_opt_tracefactory.py
+13-19Lines changed: 13 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
from plotly.exceptions import PlotlyError
44

55
import plotly.tools as tls
6+
from plotly.tests.test_optional.optional_utils import NumpyTestUtilsMixin
67
import math
78
from nose.tools import raises
89

@@ -246,7 +247,7 @@ def test_simple_streamline(self):
246247
expected_strln_0_100['x'])
247248

248249

249-
class TestDendrogram(TestCase):
250+
class TestDendrogram(NumpyTestUtilsMixin, TestCase):
250251

251252
def test_default_dendrogram(self):
252253
X = np.array([[1, 2, 3, 4], [1, 1, 3, 4], [1, 2, 1, 4], [1, 2, 3, 1]])
@@ -297,24 +298,17 @@ def test_default_dendrogram(self):
297298
'showline': True,
298299
'rangemode': 'tozero',
299300
'type': 'linear'},
300-
'hovermode': 'closest'}
301-
302-
# Make sure data is as expected
303-
self.assertEqual(len(dendro['data']), len(expected_data))
304-
for i in range(1, len(dendro['data'])):
305-
self.assertTrue(np.allclose(dendro['data'][i]['x'],
306-
expected_data[i]['x']))
307-
self.assertTrue(np.allclose(dendro['data'][i]['y'],
308-
expected_data[i]['y']))
309-
310-
# Make sure layout is as expected
311-
self.assertTrue(np.array_equal(dendro['layout']['xaxis']['ticktext'],
312-
expected_layout['xaxis']['ticktext']))
313-
self.assertTrue(np.array_equal(dendro['layout']['xaxis']['tickvals'],
314-
expected_layout['xaxis']['tickvals']))
315-
self.assertEqual(dendro['layout']['xaxis']['ticks'], 'outside')
316-
self.assertEqual(dendro['layout']['yaxis']['ticks'], 'outside')
317-
self.assertEqual(dendro['layout']['width'], expected_layout['width'])
301+
'hovermode': 'closest'}
302+
303+
expected_dendro = {'data': expected_data, 'layout': expected_layout}
304+
self.assertEqual(len(dendro['data']), 3)
305+
306+
# this is actually a bit clearer when debugging tests.
307+
self.assert_dict_equal(dendro['data'][0], expected_dendro['data'][0])
308+
self.assert_dict_equal(dendro['data'][1], expected_dendro['data'][1])
309+
self.assert_dict_equal(dendro['data'][2], expected_dendro['data'][2])
310+
311+
self.assert_dict_equal(dendro['layout'], expected_dendro['layout'])
318312

319313
def test_dendrogram_random_matrix(self):
320314
# create a random uncorrelated matrix

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.