Move Visual Studio's Utf8JsonStreamReader & extensions to NuGet Shared #6833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Without moving both implementations, I don't really see the point of moving it to shared. |
Totally! That's why I have linked a Draft PR moving that as well. Feel free to propose ways around the blocking issue I've described in that PR description. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#14579
Description
Moves the Utf8Json helper classes into NuGet Shared.
At this time, I have only moved the implementation used for Visual Studio project.json migration.
The NuGet.ProjectModel implementation references a String resource. However, I can neither add a RESX file to NuGet Shared, nor can I get the compiler to find the Strings in each consuming csproj.
See Draft #6834
Here,
Stringsis not found:Adding a Resource file to build\Shared is not supported:
PR Checklist
Added testsLink to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.