Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 850bf04

Browse filesBrowse files
authored
Merge pull request matplotlib#27875 from QuLogic/fix-macosx-timer
macosx: Clean up single-shot timers correctly
2 parents 7164087 + 9eda24f commit 850bf04
Copy full SHA for 850bf04

File tree

Expand file treeCollapse file tree

2 files changed

+5
-4
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+5
-4
lines changed

‎lib/matplotlib/backends/backend_macosx.py

Copy file name to clipboardExpand all lines: lib/matplotlib/backends/backend_macosx.py
-4Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,13 +67,9 @@ def draw_idle(self):
6767

6868
def _single_shot_timer(self, callback):
6969
"""Add a single shot timer with the given callback"""
70-
# We need to explicitly stop and remove the timer after
71-
# firing, otherwise segfaults will occur when trying to deallocate
72-
# the singleshot timers.
7370
def callback_func(callback, timer):
7471
callback()
7572
self._timers.remove(timer)
76-
timer.stop()
7773
timer = self.new_timer(interval=0)
7874
timer.single_shot = True
7975
timer.add_callback(callback_func, callback, timer)

‎src/_macosx.m

Copy file name to clipboardExpand all lines: src/_macosx.m
+5Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1746,6 +1746,11 @@ - (void)flagsChanged:(NSEvent *)event
17461746
repeats: !single
17471747
block: ^(NSTimer *timer) {
17481748
gil_call_method((PyObject*)self, "_on_timer");
1749+
if (single) {
1750+
// A single-shot timer will be automatically invalidated when it fires, so
1751+
// we shouldn't do it ourselves when the object is deleted.
1752+
self->timer = NULL;
1753+
}
17491754
}];
17501755
// Schedule the timer on the main run loop which is needed
17511756
// when updating the UI from a background thread

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.