feat: remove batch after transaction success #487
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mskrzypkows
approved these changes
Jun 3, 2025
smartprogrammer93
approved these changes
Jun 3, 2025
fb6b7da to
6200fd5
Compare
mskrzypkows
reviewed
Jun 4, 2025
| coinbase: Address, | ||
| current_l1_slot_timestamp: u64, | ||
| ) -> Result<(), Error> { | ||
| let sending_guard = match self.transaction_monitor.get_sending_guard().await { |
There was a problem hiding this comment.
We shouldn't get the guard outside the transaction monitor, that's easy way to have synchronization issues.
|
Maybe easier is to consume a batch by a transaction monitor when estimation passed? So it's removed from the batch queue and transaction monitor owns it, it can retry sending it if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.