Turn cancelled bags of holding into sacks #626
Conversation
|
It looks like commit b2d4b77 had a typo causing this PR to be closed. Re-opening. |
|
I believe I said this on IRC or elsewhere but reiterating here: I don't really like this change, not because of its own merits, but because of the door it opens. (Actually, on its own merits I kind of like the decision it sets up when you find a cursed bag of holding in bones - would you tip it and lose some contents but keep the bag as it is, or cancel it and get all the contents?) That said: If a magic bag can be cancelled into a normal bag, then shouldn't other items turn into nonmagic counterparts whenever possible? A magic harp becomes a wooden harp, magic lamp becomes an oil lamp and so on. It seems almost like polymorph (since that's another way, albeit unpredictable, to turn a magic tool into a nonmagic counterpart) - should never-polymorph-an-item conduct be broken since the item type has changed? Also, does it really make the game more fun to create enchanted -> nonenchanted mappings for items, without also having the ability to go the other way and enchant a nonenchanted item into the magic counterpart? (I would object to this a lot less if that were the case, and there's a commit in xNetHack that implements it: copperwater/xNetHack@05a8c26) |
A wand or spell of cancellation zapped at a bag of holding now turns the bag into a sack. A wand of cancellation placed directly into a bag of holding now, instead of exploding the bag, just uses one charge and cancels the bag. This is not checked for recursively; you can put a wand of cancellation into a sack and then safely put the sack into a bag of holding.
The biggest consequence of this (other than making wands of cancellation less of a hassle to carry) has to do with looting cursed bags of holding from bones. Formerly, you could just cancel the bag and pick it up. You can still do this to safely retrieve the items, but you don't get to keep the bag of holding. If you want to keep the bag, you have empty it first and risk losing some of the contents. There is now an opportunity cost.