Merge item stacks regardless of bknown #601
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, items that have been #named stack with items that have not, with the unnamed item stack acquiring the name of the named item stack as soon as the two meet each other in your inventory. This means that it's strictly better to have a stackable item informally BUC-identified than it is to have it formally BUC-identified, because then other items with the same beatitude you find later will stack with it and become (informally) BUC-identified as well.
This results in strategies like dropping only one dart on the altar and #naming the stack according to the results. To remove this tedium, I've tweaked the behavior so that formal BUC-identification behaves the same way as informal BUC-identification. Some variants already implement this change—I know Fourk does, but I'm not sure about 4.
A more radical possibility I considered was doing the same for the knowledge of the enchantment/fooproofing of an item, effectively removing the effect of ID status completely (except maybe dknown when the player is blind) on the stackability of items, but that's a larger change, so I'm saving it for a different PR.