NetHack
diff --git a/Collapse file
‎src/mkmap.c‎
Copy file name to clipboardExpand all lines: src/mkmap.c
+20Lines changed: 20 additions & 0 deletions b/Collapse file
‎src/mkmap.c‎
Copy file name to clipboardExpand all lines: src/mkmap.c
+20Lines changed: 20 additions & 0 deletions
diff --git a/Collapse file
‎src/sp_lev.c‎
Copy file name to clipboardExpand all lines: src/sp_lev.c
-3Lines changed: 0 additions & 3 deletions b/Collapse file
‎src/sp_lev.c‎
Copy file name to clipboardExpand all lines: src/sp_lev.c
-3Lines changed: 0 additions & 3 deletions
@@ -14,6 +14,7 @@ static schar get_map(int, int, schar);
 static void pass_one(schar, schar);
 static void pass_two(schar, schar);
 static void pass_three(schar, schar);
+static void join_map_cleanup(void);
 static void join_map(schar, schar);
 static void finish_map(schar, schar, boolean, boolean, boolean);
 static void remove_room(unsigned);
@@ -26,6 +27,7 @@ init_map(schar bg_typ)
 
     for (i = 1; i < COLNO; i++)
         for (j = 0; j < ROWNO; j++) {
+            levl[i][j].roomno = NO_ROOM;
             levl[i][j].typ = bg_typ;
             levl[i][j].lit = FALSE;
         }
@@ -240,6 +242,19 @@ flood_fill_rm(
         g.max_ry = sy;
 }
 
+/* join_map uses temporary rooms; clean up after it */
+static void
+join_map_cleanup(void)
+{
+    coordxy x, y;
+
+    for (x = 1; x < COLNO; x++)
+        for (y = 0; y < ROWNO; y++)
+            levl[x][y].roomno = NO_ROOM;
+    g.nroom = g.nsubroom = 0;
+    g.rooms[g.nroom].hx = g.subrooms[g.nsubroom].hx = -1;
+}
+
 static void
 join_map(schar bg_typ, schar fg_typ)
 {
@@ -311,6 +326,7 @@ join_map(schar bg_typ, schar fg_typ)
         }
         croom2++; /* always increment the next room */
     }
+    join_map_cleanup();
 }
 
 static void
@@ -349,6 +365,10 @@ finish_map(
 }
 
 /*
+ * TODO: If we really want to remove rooms after a map is plopped down
+ * in a special level, this needs to be rewritten - the maps may have
+ * holes in them ("x" mapchar), leaving parts of rooms still on the map.
+ *
  * When level processed by join_map is overlaid by a MAP, some rooms may no
  * longer be valid.  All rooms in the region lx <= x < hx, ly <= y < hy are
  * removed.  Rooms partially in the region are truncated.  This function
 
@@ -6649,9 +6649,6 @@ TODO: g.coder->croom needs to be updated
                 else if (splev_init_present && levl[x][y].typ == ICE)
                     levl[x][y].icedpool = icedpools ? ICED_POOL : ICED_MOAT;
             }
-        if (g.coder->lvl_is_joined && !g.in_mk_themerooms)
-            remove_rooms(g.xstart, g.ystart,
-                         g.xstart + g.xsize, g.ystart + g.ysize);
     }
 
  skipmap:
Original file line number	Diff line number	Diff line change
`@@ -6649,9 +6649,6 @@ TODO: g.coder->croom needs to be updated`
`6649`	`6649`	`else if (splev_init_present && levl[x][y].typ == ICE)`
`6650`	`6650`	`levl[x][y].icedpool = icedpools ? ICED_POOL : ICED_MOAT;`
`6651`	`6651`	`}`
`6652`		`- if (g.coder->lvl_is_joined && !g.in_mk_themerooms)`
`6653`		`- remove_rooms(g.xstart, g.ystart,`
`6654`		`- g.xstart + g.xsize, g.ystart + g.ysize);`
`6655`	`6652`	`}`
`6656`	`6653`
`6657`	`6654`	`skipmap:`