added GetOrCreateNodeEditorSpacePos#148
Open
sivu wants to merge 1 commit intoNelarius:masterNelarius/imnodes:masterfrom
Open
added GetOrCreateNodeEditorSpacePos#148sivu wants to merge 1 commit intoNelarius:masterNelarius/imnodes:masterfrom
sivu wants to merge 1 commit intoNelarius:masterNelarius/imnodes:masterfrom
Conversation
Owner
|
Hi @sivu ! What happens when there is no node? What are you using position for? Just thinking that some kind of mechanism is probably required in case the function is called with a node id which hasn't yet been referenced. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added GetOrCreateNodeEditorSpacePos that uses ObjectPoolFindOrCreateObject instead of asserting like GetNodeEditorSpacePos