Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat(HMR): style views at runtime #7012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 13, 2019
Merged

feat(HMR): style views at runtime #7012

merged 3 commits into from
Mar 13, 2019

Conversation

vchimev
Copy link
Contributor

@vchimev vchimev commented Mar 8, 2019 •
edited
Loading

PR Checklist

What is the current behavior?

A change in styles applies at runtime only for a Frame root applications.

What is the new behavior?

This pull request enables changes in styles to apply at runtime, no matter of the root application: layouts, Frame, TabView or SideDrawer.

Implements a part of #6953.

@cla-bot cla-bot bot added the cla: yes label Mar 8, 2019
@ghost ghost assigned vchimev Mar 8, 2019
@ghost ghost added the in progress label Mar 8, 2019
@vchimev vchimev mentioned this pull request Mar 8, 2019
Open
3 tasks
@vchimev vchimev changed the title feat(HMR): style view at runtime feat(HMR): style views at runtime Mar 8, 2019
@vchimev vchimev force-pushed the vchimev/style-view branch from 277db23 to 11aefb6 Compare March 11, 2019 11:51
@MartoYankov
Copy link
Contributor

We should add some more e2e hmr tests. For example, changing the CSS of TabView as root.

@vchimev vchimev force-pushed the vchimev/style-view branch 2 times, most recently from 11aefb6 to 4c143cc Compare March 12, 2019 13:08
manoldonev
manoldonev reviewed Mar 12, 2019
View reviewed changes
tests/app/testRunner.ts Show resolved Hide resolved
vchimev added 2 commits March 12, 2019 17:48
@vchimev
feat(HMR): style view at runtime
bef072e 
test: module root view comopnent

test: update livesync tests

refactor: _onLivesync function
@vchimev
style: remove a comment
3891f9c
@vchimev vchimev force-pushed the vchimev/style-view branch from 4c143cc to b8e87ed Compare March 12, 2019 15:48
@vchimev vchimev force-pushed the vchimev/style-view branch from b8e87ed to f9edb1b Compare March 12, 2019 15:51
@vchimev
Copy link
Contributor Author

vchimev commented Mar 13, 2019

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Mar 13, 2019

The cla-bot has been summoned, and re-checked this pull request!

@vchimev vchimev merged commit 3c2c1d9 into master Mar 13, 2019
@vchimev vchimev deleted the vchimev/style-view branch March 13, 2019 11:24
@ghost ghost removed the in progress label Mar 13, 2019
@vchimev vchimev mentioned this pull request May 3, 2019
Open
@lock
Copy link

lock bot commented Mar 12, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@manoldonev manoldonev manoldonev approved these changes

@MartoYankov MartoYankov MartoYankov approved these changes

@vakrilov vakrilov Awaiting requested review from vakrilov

Assignees

@vchimev vchimev

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vchimev @MartoYankov @manoldonev
Morty Proxy This is a proxified and sanitized view of the page, visit original site.