Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

requestAnimationFrame bug #10363

Copy link
Copy link
Open
Open
Copy link
@bigmistqke

Description

@bigmistqke
Issue body actions

Issue Description

In a nativescript + dominative + solid-js project, the app crashes in the android emulator when doing

const loop = () => requestAnimationFrame(loop); 
loop()

I could trace the bug to @nativescript/core/fps-meter/fps-native.android.js:
If I force FPSCallback.nativeFramesSupported to false with

_isNativeFramesSupported() {
  return false
}

the bug dissapears, so I assume it has something to do with global.__postFrameCallback.

Reproduction

https://github.com/bigmistqke/nativescript-raf-bug

  • yarn install
  • tns run android

Relevant log output (if applicable)

No response

Environment

OS: macOS 13.3.1
CPU: (8) arm64 Apple M1
Shell: /bin/zsh
node: 18.12.1
npm: 8.19.2
nativescript: 8.5.3

# android
java: 11.0.20
ndk: Not Found
apis: Not Found
build_tools: Not Found
system_images: Not Found

# ios
xcode: 14.2/14C18
cocoapods: Not Found
python: 2.7.18
python3: 3.11.1
ruby: 2.6.10
platforms: 
  - DriverKit 22.2
  - iOS 16.2
  - macOS 13.1
  - tvOS 16.1
  - watchOS 9.1

Dependencies

"dependencies": {
  "@nativescript-community/solid-js": "^0.0.4-alpha.4",
  "@nativescript-community/ui-collectionview": "^5.1.8",
  "@nativescript/core": "~8.5.9",
  "dominative": "^0.0.9-alpha.2",
  "prettier": "^3.0.1",
  "solid-js": "^1.7.11",
  "solid-navigation": "^1.0.0-alpha.7",
  "three": "^0.155.0",
  "undom-ng": "^1.0.10"
},
"devDependencies": {
  "@babel/core": "^7.22.10",
  "@babel/preset-env": "^7.20.2",
  "@babel/preset-typescript": "7.22.5",
  "@nativescript-dom/core-types": "^1.0.26",
  "@nativescript-dom/solidjs-types": "^1.0.11",
  "@nativescript/android": "8.5.1",
  "@nativescript/ios": "8.5.2",
  "@nativescript/webpack": "~5.0.17",
  "@types/three": "^0.155.0",
  "babel": "^6.23.0",
  "babel-loader": "^9.1.3",
  "babel-preset-solid": "^1.7.7",
  "patch-package": "^8.0.0",
  "solid-refresh": "^0.5.3",
  "typescript": "4.9.4"
}

Please accept these terms

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.