Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit a05201f

Browse filesBrowse files
committed
fix: fix for GridLayout and external UI frameworks which could not compare colums/rows to existing property
1 parent 6a5f266 commit a05201f
Copy full SHA for a05201f

File tree

Expand file treeCollapse file tree

1 file changed

+20
-6
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+20
-6
lines changed

‎packages/core/ui/layouts/grid-layout/grid-layout-common.ts

Copy file name to clipboardExpand all lines: packages/core/ui/layouts/grid-layout/grid-layout-common.ts
+20-6Lines changed: 20 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -317,16 +317,30 @@ export abstract class GridLayoutBase extends LayoutBase implements GridLayoutDef
317317

318318
protected abstract invalidate();
319319

320+
_rowsStr: string;
321+
get rows() {
322+
return this._rowsStr;
323+
}
320324
set rows(value: string) {
321-
this.removeRows();
322-
const specs = parseAndAddItemSpecs(value);
323-
this.addRows(specs);
325+
if (this._rowsStr !== value) {
326+
this._rowsStr = value;
327+
this.removeRows();
328+
const specs = parseAndAddItemSpecs(value);
329+
this.addRows(specs);
330+
}
324331
}
325332

333+
_colsStr: string;
334+
get columns() {
335+
return this._colsStr;
336+
}
326337
set columns(value: string) {
327-
this.removeColumns();
328-
const specs = parseAndAddItemSpecs(value);
329-
this.addColumns(specs);
338+
if (this._colsStr !== value) {
339+
this._colsStr = value;
340+
this.removeColumns();
341+
const specs = parseAndAddItemSpecs(value);
342+
this.addColumns(specs);
343+
}
330344
}
331345
}
332346

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.