Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 874f6b6

Browse filesBrowse files
authored
fix(root-layout): check type for translate and scale values (#10288)
1 parent 204e876 commit 874f6b6
Copy full SHA for 874f6b6

File tree

1 file changed

+3
-2
lines changed
Filter options

1 file changed

+3
-2
lines changed

‎packages/core/ui/layouts/root-layout/root-layout-common.ts

Copy file name to clipboardExpand all lines: packages/core/ui/layouts/root-layout/root-layout-common.ts
+3-2Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import { GridLayout } from '../grid-layout';
55
import { RootLayout, RootLayoutOptions, ShadeCoverOptions, TransitionAnimation } from '.';
66
import { Animation } from '../../animation';
77
import { AnimationDefinition } from '../../animation';
8+
import { isNumber } from '../../../utils/types';
89

910
@CSSType('RootLayout')
1011
export class RootLayoutBase extends GridLayout {
@@ -382,8 +383,8 @@ export class RootLayoutBase extends GridLayout {
382383
target: targetView,
383384
...defaultTransitionAnimation,
384385
...(exitTo || {}),
385-
translate: { x: exitTo.translateX || defaultTransitionAnimation.translateX, y: exitTo.translateY || defaultTransitionAnimation.translateY },
386-
scale: { x: exitTo.scaleX || defaultTransitionAnimation.scaleX, y: exitTo.scaleY || defaultTransitionAnimation.scaleY },
386+
translate: { x: isNumber(exitTo.translateX) ? exitTo.translateX : defaultTransitionAnimation.translateX, y: isNumber(exitTo.translateY) ? exitTo.translateY : defaultTransitionAnimation.translateY },
387+
scale: { x: isNumber(exitTo.scaleX) ? exitTo.scaleX : defaultTransitionAnimation.scaleX, y: isNumber(exitTo.scaleY) ? exitTo.scaleY : defaultTransitionAnimation.scaleY },
387388
};
388389
}
389390

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.