Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 7a276df

Browse filesBrowse files
committed
feat: DOM events
BREAKING CHANGE
1 parent ed14e24 commit 7a276df
Copy full SHA for 7a276df

File tree

Expand file treeCollapse file tree

13 files changed

+1086
-572
lines changed
Filter options
Expand file treeCollapse file tree

13 files changed

+1086
-572
lines changed

‎apps/automated/src/xml-declaration/xml-declaration-tests.ts

Copy file name to clipboardExpand all lines: apps/automated/src/xml-declaration/xml-declaration-tests.ts
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -409,7 +409,7 @@ export function test_parse_ShouldParseBindingsToGestures() {
409409
var observer = (<View>lbl).getGestureObservers(GestureTypes.tap)[0];
410410

411411
TKUnit.assert(observer !== undefined, 'Expected result: true.');
412-
TKUnit.assert(observer.context === context, 'Context should be equal to binding context. Actual result: ' + observer.context);
412+
TKUnit.assert(observer.observer.context === context, 'Context should be equal to binding context. Actual result: ' + observer.observer.context);
413413
}
414414

415415
export function test_parse_ShouldParseBindingsToGesturesWithOn() {
@@ -426,7 +426,7 @@ export function test_parse_ShouldParseBindingsToGesturesWithOn() {
426426
var observer = (<View>lbl).getGestureObservers(GestureTypes.tap)[0];
427427

428428
TKUnit.assert(observer !== undefined, 'Expected result: true.');
429-
TKUnit.assert(observer.context === context, 'Context should be equal to binding context. Actual result: ' + observer.context);
429+
TKUnit.assert(observer.observer.context === context, 'Context should be equal to binding context. Actual result: ' + observer.observer.context);
430430
}
431431

432432
export function test_parse_ShouldParseSubProperties() {

‎packages/core/accessibility/index.android.ts

Copy file name to clipboardExpand all lines: packages/core/accessibility/index.android.ts
+9-7Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
import * as Application from '../application';
2+
import { DOMEvent } from '../data/dom-events/dom-event';
23
import { Trace } from '../trace';
34
import { SDK_VERSION } from '../utils/constants';
45
import type { View } from '../ui/core/view';
5-
import { GestureTypes } from '../ui/gestures';
6+
import { GestureEventData, GestureTypes } from '../ui/gestures';
67
import { notifyAccessibilityFocusState } from './accessibility-common';
78
import { getAndroidAccessibilityManager } from './accessibility-service';
89
import { AccessibilityRole, AccessibilityState, AndroidAccessibilityEvent } from './accessibility-types';
@@ -54,17 +55,18 @@ function accessibilityEventHelper(view: Partial<View>, eventType: number) {
5455
* These aren't triggered for custom tap events in NativeScript.
5556
*/
5657
if (SDK_VERSION >= 26) {
57-
// Find all tap gestures and trigger them.
58-
for (const tapGesture of view.getGestureObservers(GestureTypes.tap) ?? []) {
59-
tapGesture.callback({
58+
// Trigger all tap handlers on this view.
59+
new DOMEvent('tap').dispatchTo({
60+
target: view as View,
61+
data: {
6062
android: view.android,
6163
eventName: 'tap',
6264
ios: null,
6365
object: view,
6466
type: GestureTypes.tap,
65-
view: view,
66-
});
67-
}
67+
view,
68+
} as GestureEventData,
69+
});
6870
}
6971

7072
return;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.