116 support all geometries gpu runner -- continued#129
Draft
jmaack24 wants to merge 12 commits intooptixCSP_mergeNatLabRockies/SolTrace:optixCSP_mergefrom
116-support-all-geometries---gpu-runnerNatLabRockies/SolTrace:116-support-all-geometries---gpu-runnerCopy head branch name to clipboard
Draft
116 support all geometries gpu runner -- continued#129jmaack24 wants to merge 12 commits intooptixCSP_mergeNatLabRockies/SolTrace:optixCSP_mergefrom 116-support-all-geometries---gpu-runnerNatLabRockies/SolTrace:116-support-all-geometries---gpu-runnerCopy head branch name to clipboard
jmaack24 wants to merge 12 commits intooptixCSP_mergeNatLabRockies/SolTrace:optixCSP_mergefrom
116-support-all-geometries---gpu-runnerNatLabRockies/SolTrace:116-support-all-geometries---gpu-runnerCopy head branch name to clipboard
Conversation
…NativeRunner::report_simulation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the following geometries within OptixRunner:
If there is time, adding these would also be good
The following checklist for adding Surface/Aperture combination to the OptixRunner may be of use in the future. It is recommended to add the functions in the following order:
IntersectionKernelMapinpipeline_manager.cppintersection.cu. Function name must start with__intersection__(note double underscores on both sides!!!)Aperture.h,Surface.h, andsoltrace_type.hGeometryManager::collect_geometry_infoCspElement::toDeviceGeometryDataOptixRunner::setup_elements