Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Flexvar#96

Draft
malihass wants to merge 4 commits intomainNatLabRockies/BioReactorDesign:mainfrom
flexvarNatLabRockies/BioReactorDesign:flexvarCopy head branch name to clipboard
Draft

Flexvar#96
malihass wants to merge 4 commits intomainNatLabRockies/BioReactorDesign:mainfrom
flexvarNatLabRockies/BioReactorDesign:flexvarCopy head branch name to clipboard

Conversation

@malihass
Copy link
Copy Markdown
Collaborator

@malihass malihass commented May 3, 2025

Fix #95

  • Look up the alpha threshold from phaseProperties
  • Lookup He for kla calculation
  • Make sure that Thermo properties are consistent across cases and resolve conflicts
  • Add comment in yaml files explaining where the properties (Especially WC and He coefficient) are from (@mjrahimi)
  • Make sure that Henry properties are consistent across cases and resolve conflicts
  • Make sure that dependencies are correctly handled when automating the global var writing (checked for disengagement only, but needs to be checked for all cases)
  • Some inputs are inconsistent, (mflowrate vs mflowrategas)

@malihass malihass marked this pull request as draft May 3, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Central location for Henry's constants

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.