[Fix] Fix safety issue for fsdo_dtensor #15227
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Boxiang Wang <boxiangw@oci-hsg-cs-001-vscode-01.cm.cluster>
Collaborator
Author
|
/ok to test 82a3d84 |
chtruong814
reviewed
Dec 23, 2025
| # Note: set to weights_only=True for safety reason | ||
| # It should be switching to safetensor but NeMo is deprecated. | ||
| # Please use Megatron-Bridge for better checkpointing support. | ||
| return torch.load(os.path.join(ckpt_dir, "common.pt")) |
Collaborator
There was a problem hiding this comment.
I know the latest Pytorch has weights_only=True by default, but could we pass weights_only=True explicitly? Some users may try to user older Pytorch. So best to be safe. I'm looking into whether we should declare that minimum torch version is a newer one with that default, so we can avoid this for future repos.
Updated the loading function to use weights_only=True for safety. Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information