Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[None][infra] Update the doc build stage rule by treating *.md-only P…#13358

Merged
nv-guomingz merged 1 commit intoNVIDIA:mainNVIDIA/TensorRT-LLM:mainfrom
nv-guomingz:user/guomingz/update_doc_stage_rulenv-guomingz/TensorRT-LLM:user/guomingz/update_doc_stage_ruleCopy head branch name to clipboard
Apr 24, 2026
Merged

[None][infra] Update the doc build stage rule by treating *.md-only P…#13358
nv-guomingz merged 1 commit intoNVIDIA:mainNVIDIA/TensorRT-LLM:mainfrom
nv-guomingz:user/guomingz/update_doc_stage_rulenv-guomingz/TensorRT-LLM:user/guomingz/update_doc_stage_ruleCopy head branch name to clipboard

Conversation

@nv-guomingz
Copy link
Copy Markdown
Collaborator

@nv-guomingz nv-guomingz commented Apr 23, 2026 •
edited by coderabbitai Bot
Loading

…R as docs-only CI runs

Summary by CodeRabbit

  • Refactor
    • Updated file categorization logic to better identify documentation changes by recognizing all Markdown files throughout the repository as documentation files, rather than restricting them to specific directories. Pull requests containing only Markdown changes will now be properly recognized as documentation-only submissions, preventing false positives in change classification.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@nv-guomingz
[None][infra] Update the doc build stage rule by treating *.md-only P…
e4d6452 
…R as docs-only CI runs

Signed-off-by: nv-guomingz <137257613+nv-guomingz@users.noreply.github.com>
@nv-guomingz nv-guomingz requested review from a team as code owners April 23, 2026 03:35
@nv-guomingz
Copy link
Copy Markdown
Collaborator Author

nv-guomingz commented Apr 23, 2026

/bot run

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ab87de6e-54a3-487c-a32d-239b5e3f7c19

📥 Commits

Reviewing files that changed from the base of the PR and between 9b86622 and e4d6452.

📒 Files selected for processing (1)
  • jenkins/L0_MergeRequest.groovy
📝 Walkthrough

Walkthrough

Updated the file classification logic in getOnlyOneGroupChanged to treat all Markdown files (.md) as belonging to the "Docs" group, regardless of directory location, while preserving prefix-based matching for other groups.

Changes

Cohort / File(s) Summary
Docs Group File Matching
jenkins/L0_MergeRequest.groovy		 Introduced matchesGroup predicate to differentiate "Docs" group matching logic—.md files anywhere in the repo now qualify as Docs; other groups continue using startsWith(prefix) matching. Updated both allFilesInGroup check and nonGroupFile identification to use the new predicate.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is largely incomplete, containing only the template structure with empty sections for Description, Test Coverage, and unchecked most of the PR Checklist items despite the change affecting CI/build infrastructure. Add details explaining the issue being fixed, the solution implemented, and the test coverage. Complete the PR Checklist items by verifying each point is applicable and check them appropriately.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: updating the doc build stage rule to treat markdown-only PRs as docs-only CI runs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Apr 23, 2026

PR_Github #45094 [ run ] triggered by Bot. Commit: e4d6452 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Apr 23, 2026

PR_Github #45094 [ run ] completed with state SUCCESS. Commit: e4d6452
/LLM/main/L0_MergeRequest_PR pipeline #35392 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@nv-guomingz
Copy link
Copy Markdown
Collaborator Author

nv-guomingz commented Apr 23, 2026

/bot run

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Apr 23, 2026

PR_Github #45183 [ run ] triggered by Bot. Commit: e4d6452 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Apr 23, 2026

PR_Github #45183 [ run ] completed with state SUCCESS. Commit: e4d6452
/LLM/main/L0_MergeRequest_PR pipeline #35459 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@nv-guomingz
Copy link
Copy Markdown
Collaborator Author

nv-guomingz commented Apr 24, 2026

/bot run

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Apr 24, 2026

PR_Github #45306 [ run ] triggered by Bot. Commit: e4d6452 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Apr 24, 2026

PR_Github #45306 [ run ] completed with state SUCCESS. Commit: e4d6452
/LLM/main/L0_MergeRequest_PR pipeline #35560 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@nv-guomingz
Copy link
Copy Markdown
Collaborator Author

nv-guomingz commented Apr 24, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Apr 24, 2026

PR_Github #45354 [ run ] triggered by Bot. Commit: e4d6452 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Apr 24, 2026

PR_Github #45354 [ run ] completed with state SUCCESS. Commit: e4d6452
/LLM/main/L0_MergeRequest_PR pipeline #35599 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@nv-guomingz
Copy link
Copy Markdown
Collaborator Author

nv-guomingz commented Apr 24, 2026

/bot run

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Apr 24, 2026

PR_Github #45393 [ run ] triggered by Bot. Commit: e4d6452 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Apr 24, 2026

PR_Github #45393 [ run ] completed with state SUCCESS. Commit: e4d6452
/LLM/main/L0_MergeRequest_PR pipeline #35633 completed with status: 'SUCCESS'

CI Report

Link to invocation

@nv-guomingz nv-guomingz merged commit c19081e into NVIDIA:main Apr 24, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZhanruiSunCh ZhanruiSunCh ZhanruiSunCh approved these changes

@mzweilz mzweilz Awaiting requested review from mzweilz mzweilz is a code owner automatically assigned from NVIDIA/trt-llm-ci-infra-devs

@yuanjingx87 yuanjingx87 Awaiting requested review from yuanjingx87 yuanjingx87 is a code owner automatically assigned from NVIDIA/trt-llm-infra-devs

Assignees

@nv-guomingz nv-guomingz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nv-guomingz @tensorrt-cicd @ZhanruiSunCh
Morty Proxy This is a proxified and sanitized view of the page, visit original site.