Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[TRTLLM-12137][chore] Drop non-key-model (starcoder2/mllama/nemotron) cases from L0#13315

Merged
QiJune merged 2 commits intoNVIDIA:mainNVIDIA/TensorRT-LLM:mainfrom
QiJune:deprecate_casesQiJune/TensorRT-LLM:deprecate_casesCopy head branch name to clipboard
Apr 22, 2026
Merged

[TRTLLM-12137][chore] Drop non-key-model (starcoder2/mllama/nemotron) cases from L0#13315
QiJune merged 2 commits intoNVIDIA:mainNVIDIA/TensorRT-LLM:mainfrom
QiJune:deprecate_casesQiJune/TensorRT-LLM:deprecate_casesCopy head branch name to clipboard

Conversation

@QiJune
Copy link
Copy Markdown
Collaborator

@QiJune QiJune commented Apr 22, 2026

Summary

Remove 6 redundant test cases from L0 test lists to reduce CI queue time. These tests cover older/less-critical models (Starcoder2, MLlama, Nemotron) whose coverage is already provided by downstream accuracy tests or is no longer a key model target for the corresponding platform.

Deleted tests

# Test Removed from
1 unittest/_torch/modeling -k "modeling_starcoder2" l0_a30.yml
2 unittest/_torch/modeling -k "modeling_mllama" l0_gb202.yml, l0_l40s.yml, l0_rtx_pro_6000.yml
3 unittest/_torch/modeling -k "modeling_nemotron" l0_h100.yml
4 accuracy/test_llm_api_pytorch.py::TestStarcoder2_3B::test_auto_dtype l0_h100.yml
5 accuracy/test_llm_api_pytorch.py::TestStarcoder2_7B::test_auto_dtype l0_h100.yml
6 accuracy/test_llm_api_pytorch.py::TestStarcoder2_15B::test_auto_dtype l0_h100.yml

CI time savings

Average per-run duration measured from OpenSearch CI data over the
past 7 days
(2026-04-15 → 2026-04-22).

Unit tests (run on every PR via L0_MergeRequest_PR)

Test Platform(s) Avg duration Runs (7d) Pass rate
modeling_starcoder2 A30 4 min 3 s 408 96.3%
modeling_mllama GB202 / L40S / RTX Pro 6000 8 min 1 s 1314 100%
modeling_nemotron H100 15 min 35 s 342 95.0%

Accuracy tests (run on L0_PostMerge only)

Test Platform Avg duration Runs (7d)
TestStarcoder2_3B::test_auto_dtype DGX_H100 97.8 s 16
TestStarcoder2_7B::test_auto_dtype H100_PCIe 224.2 s 2
TestStarcoder2_15B::test_auto_dtype DGX_H100 183.0 s 16

Estimated savings

  • Per PR CI run (L0_MergeRequest_PR): 243 + 481×3 + 935 ≈ 2621 s ≈ 37 min saved across A30 / GB202 / L40S / RTX Pro 6000 / H100 parallel stages.
  • Per Post-Merge run (H100): 97.8 + 224.2 + 183.0 ≈ 8.4 min saved.

Summary by CodeRabbit

  • Tests
    • Refined test configurations across multiple GPU models (A30, GB202, H100, L40S, RTX Pro 6000) to optimize test coverage and resource utilization. Adjusted model-specific test selections to better align with hardware capabilities and testing priorities, ensuring more focused validation across different accelerators.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@QiJune QiJune changed the title []test: drop non-key-model (starcoder2/mllama/nemotron) cases from L0 [TRTLLM-12137][ci] drop non-key-model (starcoder2/mllama/nemotron) cases from L0 Apr 22, 2026
@QiJune QiJune requested review from YihuiLu512 and litaotju April 22, 2026 03:21
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 22, 2026

📝 Walkthrough

Walkthrough

Multiple test configuration YAML files are modified to remove specific PyTorch modeling test selections across different GPU configurations, with one file also updating model selection comments and removing additional accuracy tests.

Changes

Cohort / File(s) Summary
Test List Removals
tests/integration/test_lists/test-db/l0_a30.yml, l0_gb202.yml, l0_l40s.yml, l0_rtx_pro_6000.yml
Removed individual unittest/_torch/modeling test entries: modeling_starcoder2 (A30), modeling_mllama (GB202, L40S, RTX Pro 6000).
Test List Update with Model Changes
tests/integration/test_lists/test-db/l0_h100.yml
Updated comment from "llama/mixtral/nemotron/deepseek" to "llama/mixtral/gemma3/gpt-oss", removed modeling_nemotron test entry, and removed three Starcoder2 accuracy test variants (TestStarcoder2_*::test_auto_dtype for 3B, 7B, 15B).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description comprehensively covers the purpose (reducing CI time), lists all deleted tests in a clear table, and provides detailed CI time savings analysis with supporting data from OpenSearch.
Title check ✅ Passed The title accurately summarizes the main change: removing non-key-model test cases (starcoder2/mllama/nemotron) from L0 test lists, which is directly reflected in all modified files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@QiJune QiJune changed the title [TRTLLM-12137][ci] drop non-key-model (starcoder2/mllama/nemotron) cases from L0 [TRTLLM-12137][chore] Drop non-key-model (starcoder2/mllama/nemotron) cases from L0 Apr 22, 2026
@QiJune QiJune changed the title [TRTLLM-12137][chore] Drop non-key-model (starcoder2/mllama/nemotron) cases from L0 [TRTLLM-12137][chore] Drop non-key-model (starcoder2/mllama/nemotron) cases from L0 Apr 22, 2026
@QiJune
Copy link
Copy Markdown
Collaborator Author

QiJune commented Apr 22, 2026

/bot run

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44869 [ run ] triggered by Bot. Commit: 72b965c Link to invocation

@QiJune QiJune requested a review from sunnyqgg April 22, 2026 12:04
QiJune added 2 commits April 22, 2026 20:13
…ists

Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
@QiJune
Copy link
Copy Markdown
Collaborator Author

QiJune commented Apr 22, 2026

/bot skip --comment "trivial changes"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44967 [ skip ] triggered by Bot. Commit: 6b9036f Link to invocation

Copy link
Copy Markdown
Collaborator

@sunnyqgg sunnyqgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44967 [ skip ] completed with state SUCCESS. Commit: 6b9036f
Skipping testing for commit 6b9036f

Link to invocation

@QiJune QiJune merged commit a1bcae6 into NVIDIA:main Apr 22, 2026
5 checks passed
ziyixiong-nv pushed a commit to ziyixiong-nv/TensorRT-LLM that referenced this pull request Apr 24, 2026
… cases from L0 (NVIDIA#13315)

Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.