Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[https://nvbugs/6018058][fix] Increase test timeout for test_fmha#12860

Merged
djns99 merged 1 commit intoNVIDIA:mainNVIDIA/TensorRT-LLM:mainfrom
djns99:dastokes/increase_test_fmha_timeoutdjns99/TensorRT-LLM:dastokes/increase_test_fmha_timeoutCopy head branch name to clipboard
Apr 30, 2026
Merged

[https://nvbugs/6018058][fix] Increase test timeout for test_fmha#12860
djns99 merged 1 commit intoNVIDIA:mainNVIDIA/TensorRT-LLM:mainfrom
djns99:dastokes/increase_test_fmha_timeoutdjns99/TensorRT-LLM:dastokes/increase_test_fmha_timeoutCopy head branch name to clipboard

Conversation

@djns99
Copy link
Copy Markdown
Collaborator

@djns99 djns99 commented Apr 8, 2026 •
edited by coderabbitai Bot
Loading

Summary by CodeRabbit

  • Tests
    • Extended test timeout duration to allow for longer execution time.
    • Removed a test waiver, re-enabling a previously skipped test case.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@djns99
[https://nvbugs/6018058][fix] Increase test timeout for test_fmha
b1abdca 
Signed-off-by: djns99 <40156487+djns99@users.noreply.github.com>
@djns99
Copy link
Copy Markdown
Collaborator Author

djns99 commented Apr 8, 2026

/bot run

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 8, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6e09ee23-568c-47b4-9513-754e7c75bf7c

📥 Commits

Reviewing files that changed from the base of the PR and between 2fe39c1 and b1abdca.

📒 Files selected for processing (2)
  • tests/integration/test_lists/test-db/l0_a100.yml
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt
📝 Walkthrough

Walkthrough

These changes update test infrastructure configurations. A post-merge test timeout is increased from 120 to 180 seconds, and a previously skipped test entry is removed from the waiver list.

Changes

Cohort / File(s) Summary
Test Configuration Updates
tests/integration/test_lists/test-db/l0_a100.yml, tests/integration/test_lists/waives.txt		 Increased test_fmha post-merge test timeout from 120s to 180s; removed test_fmha.py::test_fmha skip waiver entry from the waives list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description contains only the template structure with empty sections and no actual content explaining the issue, solution, or test coverage. Complete the Description and Test Coverage sections to explain why the timeout was increased and which tests validate the change.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: increasing a test timeout for test_fmha, directly matching the changeset modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Apr 8, 2026

PR_Github #42398 [ run ] triggered by Bot. Commit: b1abdca Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Apr 9, 2026

PR_Github #42398 [ run ] completed with state SUCCESS. Commit: b1abdca
/LLM/main/L0_MergeRequest_PR pipeline #33171 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

CI Report

Link to invocation

@djns99
Copy link
Copy Markdown
Collaborator Author

djns99 commented Apr 24, 2026

@litaotju @schetlur-nv can we get this merged?

@djns99 djns99 merged commit 98169c6 into NVIDIA:main Apr 30, 2026
9 of 10 checks passed
evezhier pushed a commit to evezhier/TensorRT-LLM that referenced this pull request May 4, 2026
@djns99 @evezhier
[https://nvbugs/6018058][fix] Increase test timeout for test_fmha (NV…
a3b54c9 
…IDIA#12860)

Signed-off-by: djns99 <40156487+djns99@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achartier achartier achartier approved these changes

@Superjomn Superjomn Awaiting requested review from Superjomn

@litaotju litaotju Awaiting requested review from litaotju

@schetlur-nv schetlur-nv Awaiting requested review from schetlur-nv

Assignees

@djns99 djns99

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@djns99 @tensorrt-cicd @achartier
Morty Proxy This is a proxified and sanitized view of the page, visit original site.