Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[None][chore] Add failed cases into waives.txt#12495

Merged
xinhe-nv merged 3 commits intoNVIDIA:mainNVIDIA/TensorRT-LLM:mainfrom
xinhe-nv:user/qa/post_update_waive_20260324_LLM_FUNCTION_CLUSTER_TEST_1336xinhe-nv/TensorRT-LLM:user/qa/post_update_waive_20260324_LLM_FUNCTION_CLUSTER_TEST_1336Copy head branch name to clipboard
Mar 25, 2026
Merged

[None][chore] Add failed cases into waives.txt#12495
xinhe-nv merged 3 commits intoNVIDIA:mainNVIDIA/TensorRT-LLM:mainfrom
xinhe-nv:user/qa/post_update_waive_20260324_LLM_FUNCTION_CLUSTER_TEST_1336xinhe-nv/TensorRT-LLM:user/qa/post_update_waive_20260324_LLM_FUNCTION_CLUSTER_TEST_1336Copy head branch name to clipboard

Conversation

@xinhe-nv
Copy link
Copy Markdown
Collaborator

@xinhe-nv xinhe-nv commented Mar 24, 2026 •
edited by coderabbitai Bot
Loading

waive failed cases.

Summary by CodeRabbit

  • Chores
    • Updated test skip list to exclude specific test cases from execution, improving test infrastructure management.

@xinhe-nv
update waive list
3b62e94 
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv xinhe-nv marked this pull request as ready for review March 25, 2026 02:02
@xinhe-nv
Merge branch 'main' into user/qa/post_update_waive_20260324_LLM_FUNCT…
ec078b3 
…ION_CLUSTER_TEST_1336

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv xinhe-nv enabled auto-merge (squash) March 25, 2026 02:03
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 25, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4a610804-d373-40f3-98d1-61769d2c9df3

📥 Commits

Reviewing files that changed from the base of the PR and between e984a7c and ec078b3.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
📝 Walkthrough

Walkthrough

This PR adds 8 SKIP entries to the test waives list for failing integration tests, covering parameterized test cases for DeepSeekV3Lite, Llama3_1_8BInstruct, and NemotronV3Super models, each linked to nvbugs references.

Changes

Cohort / File(s) Summary
Test Waives Configuration
tests/integration/test_lists/waives.txt		 Added 8 SKIP entries for failing integration test parameterizations across DeepSeekV3Lite (with various feature combinations), Llama3_1_8BInstruct (GSM8K and MMLU variants), and NemotronV3Super, each with corresponding nvbugs references.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • jieli-matrix
  • StanleySun639
  • LarryXFly
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is minimal and lacks required sections from the template including detailed explanation of what changed, why, and test coverage information. Expand the description to include: detailed explanation of which test cases are being waived and why (with NVBugs references), impact assessment, and confirmation of test coverage validation.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding failed test cases to waives.txt to skip them in CI runs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@xinhe-nv
Copy link
Copy Markdown
Collaborator Author

xinhe-nv commented Mar 25, 2026

/bot run --stage-list ""

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Mar 25, 2026

PR_Github #40215 [ run ] triggered by Bot. Commit: ec078b3 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Mar 25, 2026

PR_Github #40215 [ run ] completed with state SUCCESS. Commit: ec078b3
/LLM/main/L0_MergeRequest_PR pipeline #31352 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@xinhe-nv
Copy link
Copy Markdown
Collaborator Author

xinhe-nv commented Mar 25, 2026

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Mar 25, 2026

PR_Github #40242 [ reuse-pipeline ] triggered by Bot. Commit: ee7f6d0 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Mar 25, 2026

PR_Github #40242 [ reuse-pipeline ] completed with state SUCCESS. Commit: ee7f6d0
Reusing PR_Github #40215 (Partly Tested) for commit ee7f6d0

Link to invocation

@xinhe-nv xinhe-nv merged commit 2b5c434 into NVIDIA:main Mar 25, 2026
5 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20260324_LLM_FUNCTION_CLUSTER_TEST_1336 branch March 25, 2026 05:23
@coderabbitai coderabbitai Bot mentioned this pull request Apr 2, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LarryXFly LarryXFly LarryXFly approved these changes

@crazydemo crazydemo Awaiting requested review from crazydemo

@jieli-matrix jieli-matrix Awaiting requested review from jieli-matrix

@StanleySun639 StanleySun639 Awaiting requested review from StanleySun639

Assignees

@xinhe-nv xinhe-nv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xinhe-nv @tensorrt-cicd @LarryXFly
Morty Proxy This is a proxified and sanitized view of the page, visit original site.