Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[None][chore] Fixing guardword check#12455

Merged
pcastonguay merged 1 commit intoNVIDIA:mainNVIDIA/TensorRT-LLM:mainfrom
pcastonguay:guardword_fixpcastonguay/TensorRT-LLM:guardword_fixCopy head branch name to clipboard
Mar 23, 2026
Merged

[None][chore] Fixing guardword check#12455
pcastonguay merged 1 commit intoNVIDIA:mainNVIDIA/TensorRT-LLM:mainfrom
pcastonguay:guardword_fixpcastonguay/TensorRT-LLM:guardword_fixCopy head branch name to clipboard

Conversation

@pcastonguay
Copy link
Copy Markdown
Collaborator

@pcastonguay pcastonguay commented Mar 23, 2026 •
edited
Loading

Summary by CodeRabbit

  • Documentation
    • Updated internal documentation text for clarity regarding memory management extensibility.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@pcastonguay
Fixing guardword check
59dc084 
Signed-off-by: Patrice Castonguay <55748270+pcastonguay@users.noreply.github.com>
@pcastonguay pcastonguay requested a review from a team as a code owner March 23, 2026 12:05
@pcastonguay pcastonguay requested a review from achartier March 23, 2026 12:05
@pcastonguay
Copy link
Copy Markdown
Collaborator Author

pcastonguay commented Mar 23, 2026

/bot skip --comment "Comment change only"

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 23, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

Updated the BudgetTracker class docstring in the scheduler module to remove a specific example reference when describing future extensibility to multiple memory pools. No functional changes to code logic or behavior.

Changes

Cohort / File(s) Summary
Documentation Update
tensorrt_llm/_torch/pyexecutor/scheduler/scheduler_v2.py		 Removed example reference "(e.g. Rubin)" from BudgetTracker class docstring describing multi-memory pool extensibility.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete. Required sections such as Description, Test Coverage are empty, and no concrete details about the changes are provided. Fill in the Description section explaining what was changed and why. Add Test Coverage section documenting relevant tests. Remove template comments and provide concrete PR details.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title '[None][chore] Fixing guardword check' accurately describes the change—a documentation fix to remove an example from a docstring in the BudgetTracker class, which is a chore task.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai Bot reviewed Mar 23, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
tensorrt_llm/_torch/pyexecutor/scheduler/scheduler_v2.py (1)

1-1: ⚠️ Potential issue | 🟠 Major

Update copyright year for this modified file.

Line 1 still ends at 2025, but this file has a meaningful 2026 change in this PR. Please update the copyright year range accordingly (for example, 2022-2026).

As per coding guidelines: “Add NVIDIA copyright header on ALL new files, and update year on modified files”.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@tensorrt_llm/_torch/pyexecutor/scheduler/scheduler_v2.py` at line 1, Update
the SPDX copyright header at the top of scheduler_v2.py to reflect the file
modification in 2026 by changing the year range from "2022-2025" to "2022-2026"
(i.e., edit the first comment line in
tensorrt_llm/_torch/pyexecutor/scheduler/scheduler_v2.py to the updated year
range).
🤖 Prompt for all review comments with AI agents 
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@tensorrt_llm/_torch/pyexecutor/scheduler/scheduler_v2.py`:
- Line 1: Update the SPDX copyright header at the top of scheduler_v2.py to
reflect the file modification in 2026 by changing the year range from
"2022-2025" to "2022-2026" (i.e., edit the first comment line in
tensorrt_llm/_torch/pyexecutor/scheduler/scheduler_v2.py to the updated year
range).
ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 26beebda-ddf3-41fb-a1ad-5a81f4667b88

📥 Commits

Reviewing files that changed from the base of the PR and between 4f929fe and 59dc084.

📒 Files selected for processing (1)
  • tensorrt_llm/_torch/pyexecutor/scheduler/scheduler_v2.py

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Mar 23, 2026

PR_Github #39929 [ skip ] triggered by Bot. Commit: 59dc084 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Mar 23, 2026

PR_Github #39929 [ skip ] completed with state SUCCESS. Commit: 59dc084
Skipping testing for commit 59dc084

Link to invocation

@pcastonguay pcastonguay merged commit de96f5c into NVIDIA:main Mar 23, 2026
13 of 16 checks passed
longcheng-nv pushed a commit to longcheng-nv/TensorRT-LLM that referenced this pull request Mar 31, 2026
@pcastonguay @longcheng-nv
[None][chore] Fixing guardword check (NVIDIA#12455)
59fa45b 
Signed-off-by: Patrice Castonguay <55748270+pcastonguay@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@achartier achartier achartier approved these changes

Assignees

@pcastonguay pcastonguay

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pcastonguay @tensorrt-cicd @achartier
Morty Proxy This is a proxified and sanitized view of the page, visit original site.