Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[None][chore] Add failed cases into waives.txt#12220

Merged
xinhe-nv merged 6 commits intoNVIDIA:mainNVIDIA/TensorRT-LLM:mainfrom
xinhe-nv:user/qa/post_update_waive_20260315_LLM_FUNCTION_CLUSTER_TEST_1330xinhe-nv/TensorRT-LLM:user/qa/post_update_waive_20260315_LLM_FUNCTION_CLUSTER_TEST_1330Copy head branch name to clipboard
Mar 16, 2026
Merged

[None][chore] Add failed cases into waives.txt#12220
xinhe-nv merged 6 commits intoNVIDIA:mainNVIDIA/TensorRT-LLM:mainfrom
xinhe-nv:user/qa/post_update_waive_20260315_LLM_FUNCTION_CLUSTER_TEST_1330xinhe-nv/TensorRT-LLM:user/qa/post_update_waive_20260315_LLM_FUNCTION_CLUSTER_TEST_1330Copy head branch name to clipboard

Conversation

@xinhe-nv
Copy link
Copy Markdown
Collaborator

@xinhe-nv xinhe-nv commented Mar 15, 2026 •
edited by coderabbitai Bot
Loading

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Updated test skip entries for performance and accuracy testing configurations.

@xinhe-nv
update waive list
6925be6 
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv
Merge branch 'main' into user/qa/post_update_waive_20260315_LLM_FUNCT…
9499c8c 
…ION_CLUSTER_TEST_1330

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv xinhe-nv marked this pull request as ready for review March 16, 2026 06:34
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7ef20757-dbfe-408f-a6fe-a4c2081bfef3

📥 Commits

Reviewing files that changed from the base of the PR and between fc2bf27 and 9499c8c.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
📝 Walkthrough

Walkthrough

Added four test skip entries to the waives list: two performance tests for GB200 Deepseek models (nvbugs/5846166) and two accuracy tests for GLM4_5Air model variants (nvbugs/5981293).

Changes

Cohort / File(s) Summary
Test Waives Configuration
tests/integration/test_lists/waives.txt		 Added four SKIP entries for failing tests: two perf tests related to disagg_upload with GB200 Deepseek models, and two accuracy tests for GLM4_5Air multi-GPU and multi-model scenarios.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • jieli-matrix
  • StanleySun639
  • LarryXFly
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is minimal and lacks required sections (Description and Test Coverage) specified in the template. Expand the description with more details about which test cases are being waived and why, and clarify test coverage implications.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding failed test cases to waives.txt.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can approve the review once all CodeRabbit's comments are resolved.

Enable the reviews.request_changes_workflow setting to automatically approve the review once all CodeRabbit's comments are resolved.

@xinhe-nv
Copy link
Copy Markdown
Collaborator Author

xinhe-nv commented Mar 16, 2026

/bot run --stage-list ""

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Mar 16, 2026

PR_Github #39044 [ run ] triggered by Bot. Commit: 9499c8c Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Mar 16, 2026

PR_Github #39044 [ run ] completed with state SUCCESS. Commit: 9499c8c
/LLM/main/L0_MergeRequest_PR pipeline #30318 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@xinhe-nv xinhe-nv enabled auto-merge (squash) March 16, 2026 08:51
@xinhe-nv
Copy link
Copy Markdown
Collaborator Author

xinhe-nv commented Mar 16, 2026

/bot reuse-pipeline

@xinhe-nv
Copy link
Copy Markdown
Collaborator Author

xinhe-nv commented Mar 16, 2026

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Mar 16, 2026

PR_Github #39063 [ reuse-pipeline ] triggered by Bot. Commit: 05da96b Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Mar 16, 2026

PR_Github #39066 [ reuse-pipeline ] triggered by Bot. Commit: 05da96b Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Mar 16, 2026

PR_Github #39066 [ reuse-pipeline ] completed with state SUCCESS. Commit: 05da96b
Reusing PR_Github #39044 (Partly Tested) for commit 05da96b

Link to invocation

@xinhe-nv
Merge branch 'main' into user/qa/post_update_waive_20260315_LLM_FUNCT…
b86ba82 
…ION_CLUSTER_TEST_1330

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv
Copy link
Copy Markdown
Collaborator Author

xinhe-nv commented Mar 16, 2026

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Mar 16, 2026

PR_Github #39070 [ reuse-pipeline ] triggered by Bot. Commit: b86ba82 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Mar 16, 2026

PR_Github #39070 [ reuse-pipeline ] completed with state SUCCESS. Commit: b86ba82
Reusing PR_Github #39044 (Partly Tested) for commit b86ba82

Link to invocation

@xinhe-nv xinhe-nv merged commit 8a89887 into NVIDIA:main Mar 16, 2026
5 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20260315_LLM_FUNCTION_CLUSTER_TEST_1330 branch March 16, 2026 09:39
reasonsolo pushed a commit to reasonsolo/TensorRT-LLM that referenced this pull request Mar 17, 2026
@xinhe-nv @reasonsolo
[None][chore] Add failed cases into waives.txt (NVIDIA#12220)
0badd73 
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
@coderabbitai coderabbitai Bot mentioned this pull request Mar 19, 2026
Merged
limin2021 pushed a commit to limin2021/TensorRT-LLM that referenced this pull request Mar 19, 2026
@xinhe-nv
[None][chore] Add failed cases into waives.txt (NVIDIA#12220)
4988c48 
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
longcheng-nv pushed a commit to longcheng-nv/TensorRT-LLM that referenced this pull request Mar 31, 2026
@xinhe-nv @longcheng-nv
[None][chore] Add failed cases into waives.txt (NVIDIA#12220)
61e5f11 
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieli-matrix jieli-matrix jieli-matrix approved these changes

@crazydemo crazydemo Awaiting requested review from crazydemo

@LarryXFly LarryXFly Awaiting requested review from LarryXFly

@StanleySun639 StanleySun639 Awaiting requested review from StanleySun639

Assignees

@xinhe-nv xinhe-nv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xinhe-nv @tensorrt-cicd @jieli-matrix
Morty Proxy This is a proxified and sanitized view of the page, visit original site.