Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[None][chore] Add failed cases into waives.txt#12047

Merged
xinhe-nv merged 3 commits intoNVIDIA:mainNVIDIA/TensorRT-LLM:mainfrom
xinhe-nv:user/qa/post_update_waive_20260310_LLM_FUNCTION_CLUSTER_TEST_1312xinhe-nv/TensorRT-LLM:user/qa/post_update_waive_20260310_LLM_FUNCTION_CLUSTER_TEST_1312Copy head branch name to clipboard
Mar 11, 2026
Merged

[None][chore] Add failed cases into waives.txt#12047
xinhe-nv merged 3 commits intoNVIDIA:mainNVIDIA/TensorRT-LLM:mainfrom
xinhe-nv:user/qa/post_update_waive_20260310_LLM_FUNCTION_CLUSTER_TEST_1312xinhe-nv/TensorRT-LLM:user/qa/post_update_waive_20260310_LLM_FUNCTION_CLUSTER_TEST_1312Copy head branch name to clipboard

Conversation

@xinhe-nv
Copy link
Copy Markdown
Collaborator

@xinhe-nv xinhe-nv commented Mar 9, 2026 •
edited by coderabbitai Bot
Loading

waive failed cases.

Summary by CodeRabbit

  • Chores
    • Updated internal test execution configurations to manage test expectations across distributed model serving and data type handling scenarios.

@xinhe-nv
update waive list
1a75d9c 
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv xinhe-nv marked this pull request as ready for review March 10, 2026 07:26
@xinhe-nv xinhe-nv enabled auto-merge (squash) March 10, 2026 07:26
@xinhe-nv
Copy link
Copy Markdown
Collaborator Author

xinhe-nv commented Mar 10, 2026

/bot run --skip-test

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 10, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0513912e-acb9-4112-bb78-51532215837d

📥 Commits

Reviewing files that changed from the base of the PR and between 39d294b and 407b701.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
📝 Walkthrough

Walkthrough

This pull request adds seven new SKIP entries to the test waives list, marking specific failing test cases for Nemotron, DeepSeek, and GPTOSS models as waived. The entries target multi-GPU and distributed serving test scenarios.

Changes

Cohort / File(s) Summary
Test Waives Configuration
tests/integration/test_lists/waives.txt		 Added 7 SKIP entries for failing test cases across TestNemotronV3Super, TestDeepSeekV3Lite, and TestGPTOSS test classes, covering multi-GPU dtype and model reuse scenarios.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • jieli-matrix
  • StanleySun639
  • LarryXFly
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is missing critical sections from the template including detailed explanation, test coverage justification, and proper PR checklist completion. Expand the description to include: why these specific test cases are being waived, what test coverage validates this change, and completion of the PR checklist items.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding failed test cases to the waives.txt file, which matches the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Mar 10, 2026

PR_Github #38403 [ run ] triggered by Bot. Commit: 407b701 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Mar 10, 2026

PR_Github #38403 [ run ] completed with state SUCCESS. Commit: 407b701
/LLM/main/L0_MergeRequest_PR pipeline #29765 (Partly Tested) completed with status: 'SUCCESS'

Link to invocation

@xinhe-nv
Merge branch 'main' into user/qa/post_update_waive_20260310_LLM_FUNCT…
84adfdf 
…ION_CLUSTER_TEST_1312

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv
Copy link
Copy Markdown
Collaborator Author

xinhe-nv commented Mar 11, 2026

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Mar 11, 2026

PR_Github #38514 [ reuse-pipeline ] triggered by Bot. Commit: 84adfdf Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Mar 11, 2026

PR_Github #38514 [ reuse-pipeline ] completed with state SUCCESS. Commit: 84adfdf
Reusing PR_Github #38403 (Partly Tested) for commit 84adfdf

Link to invocation

@xinhe-nv xinhe-nv merged commit bba2981 into NVIDIA:main Mar 11, 2026
5 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20260310_LLM_FUNCTION_CLUSTER_TEST_1312 branch March 11, 2026 03:11
limin2021 pushed a commit to limin2021/TensorRT-LLM that referenced this pull request Mar 19, 2026
@xinhe-nv
[None][chore] Add failed cases into waives.txt (NVIDIA#12047)
a344fe8 
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
longcheng-nv pushed a commit to longcheng-nv/TensorRT-LLM that referenced this pull request Mar 31, 2026
@xinhe-nv @longcheng-nv
[None][chore] Add failed cases into waives.txt (NVIDIA#12047)
a47dbfa 
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanleySun639 StanleySun639 StanleySun639 approved these changes

@crazydemo crazydemo Awaiting requested review from crazydemo

@jieli-matrix jieli-matrix Awaiting requested review from jieli-matrix

@LarryXFly LarryXFly Awaiting requested review from LarryXFly

Assignees

@xinhe-nv xinhe-nv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xinhe-nv @tensorrt-cicd @StanleySun639
Morty Proxy This is a proxified and sanitized view of the page, visit original site.