Fix inconsistent Bigscape version handling #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcroci2
approved these changes
Feb 6, 2025
Contributor
gcroci2
left a comment
There was a problem hiding this comment.
Two tests are failing in tests/unit/metabolomics/test_gnps_downloader.py, but it should not be related to this PR, so I approve it.
Contributor
Author
|
Great! Yes, the failed tests are unrelated, but do I still need to do something? I get this message displayed:
|
Contributor
|
I did it for you, it worked :) @liannette |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #305
Standardizes the handling of the BiG-SCAPE version number to be a string throughout the codebase.
Changes Made
nplinker/genomics/bigscape/runbigscape.pyto expect the BiG-SCAPE version as a string instead of an integer.