Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

update GNPSExtractor class to support gnps2 #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CunliangGeng merged 8 commits into from
Jan 20, 2025
Merged

update GNPSExtractor class to support gnps2 #295

CunliangGeng merged 8 commits into from
Jan 20, 2025

Conversation

@CunliangGeng
Copy link
Member

@CunliangGeng CunliangGeng commented Jan 10, 2025 •
edited
Loading

Updated GNPSExtractor class to support gnps2 data.

This was referenced Jan 10, 2025
Merged
Merged
Merged
Merged
Merged
@CunliangGeng Graphite App
Copy link
Member Author

CunliangGeng commented Jan 10, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@CunliangGeng CunliangGeng force-pushed the update_GNPSDownloader_for_gnps2 branch from dead658 to 408fdbf Compare January 10, 2025 15:34
@CunliangGeng CunliangGeng force-pushed the update_GNPSExtractor_for_gnps2 branch from bd84fa5 to 4f9eb4e Compare January 10, 2025 15:34
@CunliangGeng CunliangGeng self-assigned this Jan 10, 2025
@CunliangGeng CunliangGeng requested a review from gcroci2 January 10, 2025 15:48
@CunliangGeng CunliangGeng marked this pull request as ready for review January 10, 2025 15:51
@CunliangGeng Graphite App
Copy link
Member Author

CunliangGeng commented Jan 20, 2025 •
edited
Loading

Merge activity

  • Jan 20, 10:36 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 20, 10:56 AM EST: Graphite rebased this pull request as part of a merge.
  • Jan 20, 10:58 AM EST: A user merged this pull request with Graphite.

@CunliangGeng CunliangGeng changed the base branch from update_GNPSDownloader_for_gnps2 to graphite-base/295 January 20, 2025 15:51
@CunliangGeng CunliangGeng changed the base branch from graphite-base/295 to dev January 20, 2025 15:54
@CunliangGeng CunliangGeng force-pushed the update_GNPSExtractor_for_gnps2 branch from 4f9eb4e to 4435369 Compare January 20, 2025 15:55
@CunliangGeng CunliangGeng merged commit 1c10b9a into dev Jan 20, 2025
2 of 3 checks passed
@CunliangGeng CunliangGeng deleted the update_GNPSExtractor_for_gnps2 branch January 20, 2025 15:58
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 20, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
15.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gcroci2 gcroci2 gcroci2 approved these changes

Assignees

@CunliangGeng CunliangGeng

Labels

None yet

Projects

dev
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CunliangGeng @gcroci2
Morty Proxy This is a proxified and sanitized view of the page, visit original site.