Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@CunliangGeng
Copy link
Member

@CunliangGeng CunliangGeng commented Jul 3, 2024

To solve issue #242.

Copy link
Member Author

CunliangGeng commented Jul 3, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CunliangGeng and the rest of your teammates on Graphite Graphite

@CunliangGeng CunliangGeng requested a review from gcroci2 July 3, 2024 10:45
@CunliangGeng CunliangGeng self-assigned this Jul 3, 2024
@CunliangGeng CunliangGeng linked an issue Jul 3, 2024 that may be closed by this pull request
@CunliangGeng CunliangGeng marked this pull request as ready for review July 3, 2024 10:45
Copy link
Member Author

CunliangGeng commented Jul 6, 2024

Merge activity

  • Jul 6, 5:45 AM EDT: @CunliangGeng started a stack merge that includes this pull request via Graphite.
  • Jul 6, 5:47 AM EDT: Graphite rebased this pull request as part of a merge.
  • Jul 6, 5:48 AM EDT: @CunliangGeng merged this pull request with Graphite.

Base automatically changed from check_disk_space to dev July 6, 2024 09:45
- fix the changed log info
- add tests for warnings on failed downloads
The requirement that download and extract folders must be different is not necessary.
@CunliangGeng CunliangGeng force-pushed the warn_failed_antismash_downloads branch from dffcbe3 to 8080748 Compare July 6, 2024 09:46
@CunliangGeng CunliangGeng merged commit 1d5f50c into dev Jul 6, 2024
@CunliangGeng CunliangGeng deleted the warn_failed_antismash_downloads branch July 6, 2024 09:48
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 6, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Podp: not all genome IDs are in antismashDB

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.