Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Update mibig downloader #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CunliangGeng merged 3 commits into from
Mar 1, 2024
Merged

Update mibig downloader #210

CunliangGeng merged 3 commits into from
Mar 1, 2024

Conversation

@CunliangGeng
Copy link
Member

@CunliangGeng CunliangGeng commented Feb 28, 2024 •
edited
Loading

add creation of mibig dir if not exist

add the support of PathLike

@CunliangGeng CunliangGeng mentioned this pull request Feb 28, 2024
Merged
@CunliangGeng Graphite App
Copy link
Member Author

CunliangGeng commented Feb 28, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CunliangGeng and the rest of your teammates on Graphite Graphite

This was referenced Feb 28, 2024
Merged
Merged
Merged
@CunliangGeng CunliangGeng requested a review from gcroci2 February 28, 2024 13:30
@CunliangGeng CunliangGeng self-assigned this Feb 28, 2024
@CunliangGeng CunliangGeng mentioned this pull request Feb 28, 2024
Closed
12 tasks
gcroci2
gcroci2 reviewed Feb 29, 2024
View reviewed changes
src/nplinker/genomics/mibig/mibig_downloader.py Outdated Show resolved Hide resolved
gcroci2
gcroci2 reviewed Feb 29, 2024
View reviewed changes
src/nplinker/genomics/mibig/mibig_downloader.py Outdated Show resolved Hide resolved
gcroci2
gcroci2 reviewed Feb 29, 2024
View reviewed changes
src/nplinker/genomics/mibig/mibig_downloader.py Outdated Show resolved Hide resolved
gcroci2
gcroci2 reviewed Feb 29, 2024
View reviewed changes
src/nplinker/genomics/mibig/mibig_downloader.py Outdated Show resolved Hide resolved
gcroci2
gcroci2 reviewed Feb 29, 2024
View reviewed changes
src/nplinker/genomics/mibig/mibig_downloader.py Outdated Show resolved Hide resolved
gcroci2
gcroci2 approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@gcroci2 gcroci2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor suggestions for the doc string.

This was referenced Mar 1, 2024
Merged
Merged
@CunliangGeng Graphite App
Copy link
Member Author

CunliangGeng commented Mar 1, 2024 •
edited
Loading

Merge activity

  • Mar 1, 9:49 AM EST: @CunliangGeng started a stack merge that includes this pull request via Graphite.
  • Mar 1, 9:52 AM EST: Graphite rebased this pull request as part of a merge.
  • Mar 1, 9:53 AM EST: @CunliangGeng merged this pull request with Graphite.

Base automatically changed from update_config to dev March 1, 2024 14:51
CunliangGeng and others added 3 commits March 1, 2024 14:51
@CunliangGeng
add creation of mibig dir if not exist
774a49b
@CunliangGeng
add the support of PathLike
a1cf06d 
-
@CunliangGeng @gcroci2
update docstrings as suggested by reviewer
a5124ed 
Co-authored-by: Giulia Crocioni <55382553+gcroci2@users.noreply.github.com>
@CunliangGeng CunliangGeng merged commit 10c37a6 into dev Mar 1, 2024
@CunliangGeng CunliangGeng deleted the update_mibig_downloader branch March 1, 2024 14:53
This was referenced Mar 5, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gcroci2 gcroci2 gcroci2 approved these changes

Assignees

@CunliangGeng CunliangGeng

Labels

None yet

Projects

dev
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CunliangGeng @gcroci2
Morty Proxy This is a proxified and sanitized view of the page, visit original site.