Redesign the template of nplinker config file #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new design does not allow users to specify the path to their data files, instead they should always put data files to default paths defined by nplinker. To keep it simple, some settings are removed in the new config template. They could be added later if really needed.
Member
Author
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
12 tasks
gcroci2
approved these changes
Feb 23, 2024
Member
Author
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR redesigned the template of nplinker config file
nplinker.toml.The new design does not allow users to specify the path to their data files, instead they should always put data files to default paths defined by NPLinker (the default paths will be provided in the next PR).
To keep it simple, some settings related to code that has not been refactored are not included in the new design. They can be added later if really needed.
Major changes:
nplinker.toml.nplinker_default.tomlNote: This PR only updated the template config file, but the usage of the configs in relevant code is not updated. Next PR will update the usage. So it's OK to see the failed test tests on
tests/scoringsandtests/test_nplinker_local.py.