Removed obsolete NET Framework 4.5 #5894

snakefoot · Jun 23, 2025

Wait for NLog v6.1

C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(1259,5): error MSB3644: The reference assemblies for .NETFramework,Version=v4.5 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks [C:\projects\nlog\src\NLog\NLog.csproj::TargetFramework=net45]

When NET45 is disappears from AppVeyor-build-agents, then it will become difficult to support.

coderabbitai · Jun 23, 2025

Walkthrough

Removed .NET Framework 4.5 (net45) targeting across build, test, packaging, and project files; build and create-package calls trimmed targetFramework lists to exclude net45, net45-specific project PropertyGroups and references were removed, and MSBuild nuspec metadata changed from net45 to net46.

Changes

Cohort / File(s)	Summary
Build script `build.ps1`	Removed `net45` from main msbuild `targetFrameworks` and from several `create-package` invocations; create-package signature unchanged.
Test runner script `run-tests.ps1`	Deleted Windows-only net45 build/test block (msbuild/vstest and exit-code checks) for net45.
Project PropertyGroup removals `src/NLog.OutputDebugString/NLog.OutputDebugString.csproj`, `src/NLog.RegEx/NLog.RegEx.csproj`, `src/NLog.Targets.GZipFile/NLog.Targets.GZipFile.csproj`, `src/NLog/NLog.csproj`	Removed conditional `<PropertyGroup Condition="$(TargetFramework) == 'net45'">` blocks (titles, `DisableImplicitFrameworkReferences`, and `DebugType` where present).
Project refs removed for net45 `src/NLog.Targets.AtomicFile/NLog.Targets.AtomicFile.csproj`	Removed net45-specific `<PropertyGroup>` and net45 `<ItemGroup>` references to `System`/`System.Core`.
Test project constants `tests/NLog.UnitTests/NLog.UnitTests.csproj`	Removed conditional that defined the `NET45` compilation symbol when targeting `TestTargetFramework=net45`.
Packaging / MSBuild metadata `src/NLog.proj`	Switched nuspec/MSBuild packaging metadata from `net45` to `net46` (TargetFramework Include, ProjectFileSuffix, NuGetDir).

Sequence Diagram(s)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

I nibbled the net45 thread from the patch,
Swapped it for net46, a tidy little match.
Builds hop lighter, tests skip a lane,
Carrots in packages, snug and plain.
— A rabbit with a rake, happy with the batch 🥕

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 544d1f8 and 9e2bb95.

📒 Files selected for processing (9)

build.ps1 (2 hunks)
run-tests.ps1 (0 hunks)
src/NLog.OutputDebugString/NLog.OutputDebugString.csproj (0 hunks)
src/NLog.RegEx/NLog.RegEx.csproj (0 hunks)
src/NLog.Targets.AtomicFile/NLog.Targets.AtomicFile.csproj (0 hunks)
src/NLog.Targets.GZipFile/NLog.Targets.GZipFile.csproj (0 hunks)
src/NLog.proj (1 hunks)
src/NLog/NLog.csproj (0 hunks)
tests/NLog.UnitTests/NLog.UnitTests.csproj (0 hunks)

💤 Files with no reviewable changes (7)

src/NLog.RegEx/NLog.RegEx.csproj
src/NLog.OutputDebugString/NLog.OutputDebugString.csproj
tests/NLog.UnitTests/NLog.UnitTests.csproj
src/NLog/NLog.csproj
src/NLog.Targets.GZipFile/NLog.Targets.GZipFile.csproj
run-tests.ps1
src/NLog.Targets.AtomicFile/NLog.Targets.AtomicFile.csproj

🚧 Files skipped from review as they are similar to previous changes (1)

src/NLog.proj

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: task-list-completed
GitHub Check: task-list-completed
GitHub Check: task-list-completed

🔇 Additional comments (4)

build.ps1 (4)
26-26: net45 removal in main pack: LGTM.

The updated targetFrameworks for NLog core correctly drops net45 while preserving net35 and netstandard TFMs.

38-38: Confirm: Did you also intend to drop net35 for NLog.Targets.GZipFile?

PR title/purpose is net45 removal, but this line also removes net35 (unlike OutputDebugString/RegEx which keep net35). If unintentional, restore net35:
-create-package 'NLog.Targets.GZipFile' '"net46;netstandard2.0;netstandard2.1"'
+create-package 'NLog.Targets.GZipFile' '"net35;net46;netstandard2.0;netstandard2.1"'
39-40: Target list updates for OutputDebugString/RegEx: LGTM.

Both correctly drop net45 and keep net35 + netstandard TFMs.

44-44: Leftover BuildNetFX45 flag — likely inconsistent with dropping net45.

If NLog.proj no longer uses/defines BuildNetFX45 or switched to net46, this may be a no-op or cause confusion. Prefer removing or updating to the new flag.

Option A (remove the flag if unused):
-msbuild /t:xsd /t:NuGetSchemaPackage ./src/NLog.proj /p:Configuration=Release /p:BuildNetFX45=true /p:BuildVersion=$versionProduct /p:Configuration=Release /p:BuildLabelOverride=NONE /verbosity:minimal
+msbuild /t:xsd /t:NuGetSchemaPackage ./src/NLog.proj /p:Configuration=Release /p:BuildVersion=$versionProduct /p:Configuration=Release /p:BuildLabelOverride=NONE /verbosity:minimal
To verify what to do, run:
#!/bin/bash
# Find any remaining usage/definition of BuildNetFX45
rg -nP 'BuildNetFX45' -C3
# Also check for a replacement flag (e.g., BuildNetFX46)
rg -nP 'BuildNetFX46|BuildNetFx46|BuildNet46' -C3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

sonarqubecloud · Jul 10, 2025

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

coderabbitai

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)

build.ps1 (2)

38-40: net45 still targeted in create-package calls — remove to complete the drop.

These calls still pass net45 and will be inconsistent with the csproj changes (and can fail Pack). Remove net45 here.

-create-package 'NLog.Targets.GZipFile' '"net45;net46;netstandard2.0;netstandard2.1"'
+create-package 'NLog.Targets.GZipFile' '"net46;netstandard2.0;netstandard2.1"'

-create-package 'NLog.OutputDebugString' '"net35;net45;net46;netstandard2.0;netstandard2.1"'
+create-package 'NLog.OutputDebugString' '"net35;net46;netstandard2.0;netstandard2.1"'

-create-package 'NLog.RegEx' '"net35;net45;net46;netstandard2.0;netstandard2.1"'
+create-package 'NLog.RegEx' '"net35;net46;netstandard2.0;netstandard2.1"'

44-44: Schema packaging still toggles BuildNetFX45 — update to net46.

Align the schema packaging flag with the new net46 baseline.

-msbuild /t:xsd /t:NuGetSchemaPackage ./src/NLog.proj /p:Configuration=Release /p:BuildNetFX45=true /p:BuildVersion=$versionProduct /p:Configuration=Release /p:BuildLabelOverride=NONE /verbosity:minimal
+msbuild /t:xsd /t:NuGetSchemaPackage ./src/NLog.proj /p:Configuration=Release /p:BuildNetFX46=true /p:BuildVersion=$versionProduct /p:Configuration=Release /p:BuildLabelOverride=NONE /verbosity:minimal

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 70a7d47 and 544d1f8.

📒 Files selected for processing (9)

build.ps1 (1 hunks)
run-tests.ps1 (0 hunks)
src/NLog.OutputDebugString/NLog.OutputDebugString.csproj (0 hunks)
src/NLog.RegEx/NLog.RegEx.csproj (0 hunks)
src/NLog.Targets.AtomicFile/NLog.Targets.AtomicFile.csproj (0 hunks)
src/NLog.Targets.GZipFile/NLog.Targets.GZipFile.csproj (0 hunks)
src/NLog.proj (1 hunks)
src/NLog/NLog.csproj (0 hunks)
tests/NLog.UnitTests/NLog.UnitTests.csproj (0 hunks)

💤 Files with no reviewable changes (7)

src/NLog.RegEx/NLog.RegEx.csproj
src/NLog/NLog.csproj
src/NLog.OutputDebugString/NLog.OutputDebugString.csproj
src/NLog.Targets.AtomicFile/NLog.Targets.AtomicFile.csproj
tests/NLog.UnitTests/NLog.UnitTests.csproj
src/NLog.Targets.GZipFile/NLog.Targets.GZipFile.csproj
run-tests.ps1

🚧 Files skipped from review as they are similar to previous changes (1)

src/NLog.proj

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: task-list-completed
GitHub Check: task-list-completed
GitHub Check: task-list-completed

🔇 Additional comments (1)

build.ps1 (1)

26-26: LGTM: net45 removed from main NLog pack.

Targets now align with the PR scope (net46/net35/netstandard2.0/netstandard2.1).

build.ps1

sonarqubecloud · Sep 7, 2025

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

pull-request-size bot added the size/L label Jun 23, 2025

snakefoot force-pushed the net45_remove branch from 3605e7c to ad6ebbe Compare June 23, 2025 05:50

snakefoot force-pushed the net45_remove branch from ad6ebbe to 70a7d47 Compare July 10, 2025 12:58

snakefoot force-pushed the net45_remove branch from 70a7d47 to d7862ef Compare September 7, 2025 08:58

pull-request-size bot added size/M and removed size/L labels Sep 7, 2025

snakefoot force-pushed the net45_remove branch from d7862ef to 544d1f8 Compare September 7, 2025 08:59

coderabbitai bot reviewed Sep 7, 2025

View reviewed changes

build.ps1 Show resolved Hide resolved

Removed obsolete NET Framework 4.5

9e2bb95

snakefoot force-pushed the net45_remove branch from 544d1f8 to 9e2bb95 Compare September 7, 2025 09:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Removed obsolete NET Framework 4.5 #5894

Removed obsolete NET Framework 4.5 #5894

Uh oh!

snakefoot commented Jun 23, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jun 23, 2025 •

edited

Loading

Review ran into problems

Uh oh!

sonarqubecloud bot commented Jul 10, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Sep 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Search code, repositories, users, issues, pull requests...

Removed obsolete NET Framework 4.5 #5894

Are you sure you want to change the base?

Removed obsolete NET Framework 4.5 #5894

Uh oh!

Conversation

snakefoot commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Poem

Review ran into problems

Uh oh!

sonarqubecloud bot commented Jul 10, 2025

Quality Gate passed

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Sep 7, 2025

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

snakefoot commented Jun 23, 2025 •

edited

Loading

coderabbitai bot commented Jun 23, 2025 •

edited

Loading