Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@bouweandela
Copy link
Member

@bouweandela bouweandela commented Aug 27, 2024

Checklist before requesting a review

  • I have read the contribution guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • All user facing changes have been added to CHANGELOG.md

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

List of related issues or pull requests**

None

Describe the changes made in this pull request

Remove unused isort configuration again since #392 seems to have gotten undone in #399.

@bouweandela bouweandela marked this pull request as ready for review August 27, 2024 13:29
@fdiblen fdiblen self-requested a review August 28, 2024 09:06
Copy link
Member

@fdiblen fdiblen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @bouweandela. Thank you!
You can merge it ;)

@bouweandela bouweandela merged commit 953db45 into main Aug 28, 2024
@bouweandela bouweandela deleted the remove-unused-isort-config branch August 28, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.