Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@fdiblen
Copy link
Member

@fdiblen fdiblen commented Aug 22, 2024

Checklist

Description:

  • splitted copier.yml into multiple files and placed under copier/ folder. Here are the new yaml files:
    • questions/
      • essential.yml: questions asked for every profile
      • features.yml: questions about (optional) features
      • package_details.yml: extra questions about package meta data
    • messages.yml: messages for the users
    • profiles.yml: profile selection
    • settings.yml: general settings for copier
  • updated the profile question
  • updated the validator text for package_name question
  • using placeholder for most of the questions
  • added help field for the questions missing that field
  • added extra question to ask if user wants to add more information about the package
  • added skip setting which ignores some files when merging
  • fixed the full_name field in docs/conf.py
  • updated the unit tests to work with placeholders
  • made Apache 2.0 the default license

Related issues:

Instructions to review the pull request

Generate packages with different feature combinations and check if you get the expected results.

cd $(mktemp -d --tmpdir py-tmpl-XXXXXX)
copier copy --vcs-ref 440_default_values https://github.com/nlesc/python-template test_copier

# Create a local git repo to push to GitHub to trigger CI actions
cd test_copier
git init
git add --all
git commit -m "First commit"
git remote add origin git@github.com:<you>/python-template-test.git
git push -u origin main -f

@fdiblen fdiblen changed the title 440-Organize questions 440-Organize copier questions Aug 22, 2024
@fdiblen fdiblen marked this pull request as ready for review August 22, 2024 15:52
@fdiblen fdiblen requested a review from lyashevska August 22, 2024 15:53
copier/profiles.yml Show resolved Hide resolved
copier/questions/essential.yml Show resolved Hide resolved
copier/profiles.yml Show resolved Hide resolved
copier.yml Outdated Show resolved Hide resolved
copier.yml Outdated Show resolved Hide resolved
copier/profiles.yml Show resolved Hide resolved
copier/questions/features.yml Outdated Show resolved Hide resolved
copier/questions/features.yml Outdated Show resolved Hide resolved
copier/questions/package_details.yml Outdated Show resolved Hide resolved
copier/questions/package_details.yml Outdated Show resolved Hide resolved
copier/questions/package_details.yml Show resolved Hide resolved
Copy link
Collaborator

@lyashevska lyashevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @fdiblen Great work! I have made a few comments/suggestions.

copier/questions/package_details.yml Show resolved Hide resolved
copier/profiles.yml Show resolved Hide resolved
fdiblen and others added 4 commits August 23, 2024 16:39
Co-authored-by: Olga Lyashevska <olga.lyashevska@gmail.com>
Co-authored-by: Olga Lyashevska <olga.lyashevska@gmail.com>
Co-authored-by: Olga Lyashevska <olga.lyashevska@gmail.com>
Co-authored-by: Olga Lyashevska <olga.lyashevska@gmail.com>
copier/questions/essential.yml Show resolved Hide resolved
fdiblen and others added 2 commits August 23, 2024 17:01
Co-authored-by: Olga Lyashevska <olga.lyashevska@gmail.com>
Co-authored-by: Olga Lyashevska <olga.lyashevska@gmail.com>
Copy link
Collaborator

@lyashevska lyashevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @fdiblen I like a lot that now we have a separate 'copier' folder with all the files. This simplifies things a lot. It looks good, we can merge this and polish things separately.

@fdiblen fdiblen merged commit 6663b8c into main Aug 23, 2024
@fdiblen fdiblen deleted the 440_default_values branch August 23, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.