Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@sverhoeven
Copy link
Member

@sverhoeven sverhoeven commented Aug 21, 2024

Fixes #457

Description

Instructions to review the pull request

When you do

🎤 Add pre-commit hook to check code style and format on every commit?
   Yes

There should be .githooks/pre-commit file and README.dev.md mentions it.

When you do the opposit. That file and mention should not exist.

@sverhoeven sverhoeven marked this pull request as ready for review August 21, 2024 12:03
Copy link
Collaborator

@lyashevska lyashevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sverhoeven I reviewed it and everything works as expected.

@lyashevska lyashevska merged commit 1d454b0 into main Aug 21, 2024
@lyashevska lyashevska deleted the 457-optional-precommit branch August 21, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add optional question to copier questionnaire: pre-commit

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.