Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit bfba27d

Browse filesBrowse files
authored
Merge pull request plotly#1182 from plotly/schema-metakey-fix
Fix defs.metaKeys field
2 parents d9caee9 + 744041b commit bfba27d
Copy full SHA for bfba27d

File tree

Expand file treeCollapse file tree

2 files changed

+8
-1
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+8
-1
lines changed

‎src/plot_api/plot_schema.js

Copy file name to clipboardExpand all lines: src/plot_api/plot_schema.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ exports.get = function() {
6161
return {
6262
defs: {
6363
valObjects: Lib.valObjects,
64-
metaKeys: UNDERSCORE_ATTRS.concat['description', 'role']
64+
metaKeys: UNDERSCORE_ATTRS.concat(['description', 'role'])
6565
},
6666

6767
traces: traces,

‎test/jasmine/tests/plotschema_test.js

Copy file name to clipboardExpand all lines: test/jasmine/tests/plotschema_test.js
+7Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -187,4 +187,11 @@ describe('plot schema', function() {
187187
expect(attrNames).toContain(k);
188188
});
189189
});
190+
191+
it('should list correct defs', function() {
192+
expect(plotSchema.defs.valObjects).toBeDefined();
193+
194+
expect(plotSchema.defs.metaKeys)
195+
.toEqual(['_isSubplotObj', '_isLinkedToArray', '_deprecated', 'description', 'role']);
196+
});
190197
});

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.