Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit ceed366

Browse filesBrowse files
authored
Merge pull request coreui#91 from coreui/dev-v2.5.3
v2.5.3
2 parents cfd4319 + 4e065c9 commit ceed366
Copy full SHA for ceed366

File tree

Expand file treeCollapse file tree

7 files changed

+181
-17
lines changed
Filter options
Expand file treeCollapse file tree

7 files changed

+181
-17
lines changed

‎CHANGELOG.md

Copy file name to clipboardExpand all lines: CHANGELOG.md
+12Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,17 @@
11
### [@coreui/react](https://coreui.io/) changelog
22

3+
##### `v2.5.3`
4+
- fix(SidebarNav): add missing `itemAttr` to item/item with children (optional)
5+
- chore: update demo styles `@coreui/coreui` to `v2.1.12`
6+
7+
###### dependencies update
8+
- update `react` to `^16.10.1`
9+
- update `react-dom` to `^16.10.1`
10+
- update `react-router-dom` to `^5.1.2`
11+
- update `babel-eslint` to `^10.0.3`
12+
- update `eslint-plugin-react` to `^7.15.1`
13+
- update `webpack-dev-server` to `^3.8.1`
14+
315
##### `v2.5.2`
416
- fix(Switch): does not provide any keyboard accessibility - thanks @roastery-zz close #44
517
- fix(Switch): checked props and state out of sync - thanks @gravitymedianet @jinixx

‎demo/src/scss/style.css

Copy file name to clipboardExpand all lines: demo/src/scss/style.css
+138-2Lines changed: 138 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json

Copy file name to clipboardExpand all lines: package.json
+9-9Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@coreui/react",
3-
"version": "2.5.2",
3+
"version": "2.5.3",
44
"description": "CoreUI React Bootstrap 4 components",
55
"license": "MIT",
66
"author": {
@@ -45,22 +45,22 @@
4545
},
4646
"peerDependencies": {
4747
"@coreui/coreui": "^2.1.12",
48-
"react": "^16.8.6",
49-
"react-router-dom": "^5.0.1"
48+
"react": "^16.10.1",
49+
"react-router-dom": "^5.1.2"
5050
},
5151
"devDependencies": {
52-
"babel-eslint": "^10.0.2",
52+
"babel-eslint": "^10.0.3",
5353
"enzyme": "^3.10.0",
5454
"enzyme-adapter-react-16": "^1.14.0",
5555
"eslint": "^5.16.0",
5656
"eslint-plugin-import": "^2.18.2",
57-
"eslint-plugin-react": "^7.14.3",
57+
"eslint-plugin-react": "^7.15.1",
5858
"nwb": "^0.23.0",
59-
"react": "^16.8.6",
60-
"react-dom": "^16.8.6",
61-
"react-router-dom": "^5.0.1",
59+
"react": "^16.10.1",
60+
"react-dom": "^16.10.1",
61+
"react-router-dom": "^5.1.2",
6262
"sinon": "^5.1.1",
63-
"webpack-dev-server": "^3.7.2"
63+
"webpack-dev-server": "^3.8.1"
6464
},
6565
"repository": {
6666
"type": "git",

‎src/Breadcrumb.js

Copy file name to clipboardExpand all lines: src/Breadcrumb.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ const BreadcrumbsItem = ({ match }) => {
2828
const routeName = findRouteName(match.url);
2929
if (routeName) {
3030
return (
31+
// eslint-disable-next-line react/prop-types
3132
match.isExact ?
3233
<BreadcrumbItem active>{routeName}</BreadcrumbItem>
3334
:

‎src/Breadcrumb2.js

Copy file name to clipboardExpand all lines: src/Breadcrumb2.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ const BreadcrumbsItem2 = ({ match }) => {
3030
const Link = router.Link;
3131
if (routeName) {
3232
return (
33+
// eslint-disable-next-line react/prop-types
3334
match.isExact ?
3435
<BreadcrumbItem active>{routeName}</BreadcrumbItem>
3536
:

‎src/SidebarNav.md

Copy file name to clipboardExpand all lines: src/SidebarNav.md
+4-2Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,8 @@ router | inject `react-router-dom@5` object | _mandatory for @coreui/react ^2.5.
4949
text: 'NEW',
5050
class: '' // optional
5151
},
52-
attributes: { target: '_blank', rel: "noreferrer noopener", disabled: false, hidden: false }, // (v2.1.0 up) optional valid JS object with JS API naming
52+
attributes: { target: '_blank', rel: "noreferrer noopener", disabled: false, hidden: false }, // (v2.1.0 up) link html attributes - optional valid JS object with JS API naming
53+
itemAttr: { id: 'item-1'}, // item html attributes - optional
5354
},
5455
```
5556
- item with `children` array - works like `nav-dropdown-toggle` with `nav-dropdown-items`
@@ -59,7 +60,8 @@ router | inject `react-router-dom@5` object | _mandatory for @coreui/react ^2.5.
5960
url: '/icons',
6061
icon: 'icon-star',
6162
class: 'text-uppercase', // (v2.5.1 up) optional
62-
attributes: { class: 'bg-success' }, // (v2.5.1 up) optional valid JS object with JS API naming,
63+
attributes: { class: 'bg-success' }, // (v2.5.1 up) nav-dropdown link html attributes - optional valid JS object with JS API naming,
64+
itemAttr: { id: 'drop-1' }, // (v2.5.3 up) item html attributes - optional
6365
children: [
6466
{
6567
name: 'Flags', // item options apply

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.