Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

MudSwitch: Don't scale label text with Size property #11132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
Loading
from

Conversation

danielchalmers
Copy link
Member

Description

See #11099 (comment)

The font size is now correctly body1 as opposed to the previously hardcoded styles. There will be a minor effect on applications.

How Has This Been Tested?

visually

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Before

image

After

image

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.00%. Comparing base (cd3ef08) to head (46d1723).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #11132      +/-   ##
==========================================
- Coverage   91.01%   91.00%   -0.02%     
==========================================
  Files         436      436              
  Lines       14095    14094       -1     
  Branches     2724     2726       +2     
==========================================
- Hits        12829    12826       -3     
  Misses        651      651              
- Partials      615      617       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ArieGato
Copy link
Contributor

ArieGato commented Apr 2, 2025

@henon
Copy link
Collaborator

henon commented Apr 3, 2025

If @Garderoben is good with this I am not against it. I guess we should we merge this with v9?

@henon henon removed their request for review April 3, 2025 07:39
@ArieGato
Copy link
Contributor

ArieGato commented Apr 3, 2025

Before merging I really think that there is still one issue with it.

Copy link

sonarqubecloud bot commented Apr 4, 2025

@danielchalmers danielchalmers changed the title MudSwitch: No longer scale label with the Size property MudSwitch: Don't scale label text with Size property May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.