-
Notifications
You must be signed in to change notification settings - Fork 1
Demo feature pr #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
We now require numpy 1.16 (per setup.py and NEP29).
... per dev call. The docstring of add_axes/add_subplot still needs to be changed, but this should wait until after projection reuse behavior is finalized. Also, cases of polar=True in the tests have been left as such, to keep exercising that API.
A single implementation can be written in the base class. Also, the alignment groupers only need to be defined in FigureBase; we don't need to redefine them in the Figure subclass.
ENH: add redirect_from sphinx extension Co-authored-by: Antony Lee <anntzer.lee@gmail.com> Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
…acement DOC: add fixed-aspect colorbar examples
Previously the non-interactive backends, other than Agg, did not define `draw` methods and fell back to the base no-op version. However, we have been documenting that the correct way to update the various internal state we keep (run tight/constrained layouts, auto limits, text size/position, ...), this is now a bug due to our suggested usage drifting. closes matplotlib#18407
Move the marks to skip if various latex installs are missing to be visible on other modules.
The full artist tree needs to be walked in `draw` to ensure that deferred work is done.
DOC: use config.yml to redirect questions from GH issues to discourse
TST: Skip setting up a tmpdir in tests that don't need one.
DOC: better intro for dates.py
It was accidentally ignored since 154a616.
Dedupe docstrings of Figure.{get_axes,axes}.
Prefer Axes.remove() over Figure.delaxes() in docs.
…-kerning Add kerning to single-byte strings in PDFs
Clean up E265 in examples.
Fix handling of warn keyword in in Figure.show.
Also check that the first element of the a list layout is not a string. closes matplotlib#19631
FIX: do not allow single element list of str in subplot_mosaic
pick_events were previously incorrectly emitted twice due to the combination of two recent(ish) chnages: Figures now always start with a FigureCanvasBase attached -- eventually switching to a concrete subclass of FigureCanvasBase for display or saving --, and callbacks are now actually stored at the Figure level rather than the Canvas level. Hence, the button_pick_id callback (in charge of emitting picks) would previously be both registered both through the FigureCanvasBase and the concrete subclass. The fix is to also move that callback to the Figure level, so that each Figure only has one such callback.
It was accidentally(?) added to the public API in the yet-to-be-released 1173770.
Fix double picks.
This function copies minpos when frozen is called. This commit resolves matplotlib#19296. Co-authored-by: Agriad <agriad1@yahoo.com> Co-authored-by: davek10 <94davek@gmail.com> Co-authored-by: tjr16 <jerryaccount@126.com>
Fix comment in RectangleSelector
Don't turn check_for_pgf into public API.
Fix Bbox.frozen() not copying minposx/minposy
Restore _AxesStack to track a Figure's Axes order.
This prevents segfaults when multiple threads try to manipulate the FT2Font object simultaneously. closes matplotlib#19560 Co-authored-by: Antony Lee <anntzer.lee@gmail.com>
FIX: make the cache in font_manager._get_font keyed by thread id
Use globals() instead of locals() for adding colormaps as names to cm module
Co-authored-by: hannah <story645@gmail.com>
Improve docs for rgba conversion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers
or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
d6061d4
to
bd7df78
Compare
PR Summary
Demo PR to check team contribution flow.
PR Checklist
pytest
passes).flake8
on changed files to check).flake8-docstrings
and runflake8 --docstring-convention=all
).doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).