Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Update docs and sln files#1

Open
Budtom wants to merge 10 commits intoMidLevel:masterMidLevel/MLAPI.Relay:masterfrom
Budtom:Update-docs-and-sln-filesBudtom/MLAPI.Relay:Update-docs-and-sln-filesCopy head branch name to clipboard
Open

Update docs and sln files#1
Budtom wants to merge 10 commits intoMidLevel:masterMidLevel/MLAPI.Relay:masterfrom
Budtom:Update-docs-and-sln-filesBudtom/MLAPI.Relay:Update-docs-and-sln-filesCopy head branch name to clipboard

Conversation

@Budtom
Copy link

@Budtom Budtom commented Sep 24, 2019

No description provided.

@TwoTenPvP
Copy link
Member

Some questions regarding this pullrequest. Why have you included UnityEditor.dll? It's not required.

Where did you get the UnityEngine.dll from? We are not allowed to willy nilly distribute the UnityEngine dll.

Why did you include Ruffles as binary? It should be resolved via Nuget (and it is). It does not need a binary file.

@Budtom
Copy link
Author

Budtom commented Sep 26, 2019

Why have you included UnityEditor.dll? It's not required.
The build threw an error at runtime without the reference to the dll, with an error message asking for it's reference.

Where did you get the UnityEngine.dll from? We are not allowed to willy nilly distribute the UnityEngine dll.
Sorry I did not realise that! I grabbed it from my local install

Why did you include Ruffles as binary? It should be resolved via Nuget (and it is). It does not need a binary file.
Again I got a runtime error without including it and to be honest no idea why I didn't realise it was from nuget. It doesn't get included into the release folder automatically hence the < CopyLocalLockFileAssemblies csproj line

MLAPI.Relay/MLAPI.Relay.csproj Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments

Close sidebar
Morty Proxy This is a proxified and sanitized view of the page, visit original site.