Fixed invalid argument validation in LZ4Codec #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! nicely detected. |
|
Love this Project! Keep up the great work! Will try to audit it entirely. =) |
AbhitejJohn
pushed a commit
to AbhitejJohn/MessagePack-CSharp
that referenced
this pull request
Dec 12, 2018
…geVersions Consolidate package versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arguments from MessagePack.LZ4.CheckArguments(byte[], int, int, byte[], int, int) are validated incorrectly.
Case 1:
MessagePack.LZ4.CheckArguments(new byte[0], int.MaxValue, 1, new byte[0], int.MaxValue, 1);
Expected:
throw ArgumentOutOfRangeException
Actual:
no Exception thrown, because of overflow at
inputOffset + inputLength.Case 2:
MessagePack.LZ4.CheckArguments(new byte[0], 5, -5, new byte[0], 5, -5);
Expected:
throw ArgumentOutOfRangeException
Actual:
no Exception thrown, because
inputOffset + inputLength == 0.