Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

ReactivePropertySlimに対応 #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 26, 2018
Merged

ReactivePropertySlimに対応 #239

merged 3 commits into from
Apr 26, 2018

Conversation

reniris
Copy link

@reniris reniris commented Apr 24, 2018

ReactivePropertySlimResolverを追加
ReactivePropertyのバージョンアップにより、.NET4.5のサポートを切って.NET4.6をサポート。
これでReactivePropertyも正常にシリアライズ、デシリアライズできます。

@neuecc
Copy link
Member

neuecc commented Apr 25, 2018

ありがとうございます、良いと思います！
ただ、Resolverは分ける必要がないと思うので、↓のあたりに追加して統合していただければです。
https://github.com/reniris/MessagePack-CSharp/blob/80d3bf2d53dd396aeab44279efdee6d8d812fd31/src/MessagePack.ReactiveProperty/ReactivePropertyResolver.cs#L37-L43

@reniris
Copy link
Author

reniris commented Apr 25, 2018

わかりました。しばらくお待ちください。

@reniris
Copy link
Author

reniris commented Apr 25, 2018

Resolverを統合してSlimResolverブランチを更新しました。
IReactivePropertyは何もしていません。

@reniris
Copy link
Author

reniris commented Apr 25, 2018

新しくIFRPropブランチを切って、IReactivePropertyのシリアライズ、デシリアライズをReactivePropertySlimに対応させました。
https://github.com/reniris/MessagePack-CSharp/tree/IFRProp

@neuecc
Copy link
Member

neuecc commented Apr 25, 2018

どうもです、OKかとー。
Interfaceのもなるほどそうですね。
このPRで両対応にしちゃっていいと思うので混ぜちゃってください。
そうしたらマージします。

@reniris
Copy link
Author

reniris commented Apr 26, 2018

マージしました。

@neuecc neuecc merged commit 9a7fa63 into MessagePack-CSharp:master Apr 26, 2018
@neuecc
Copy link
Member

neuecc commented Apr 26, 2018

どうもです、マージしました！
リリースは、ちょっと幾つか溜まってる必須Issueを片付けた時と同タイミングを考えています。

@AArnott AArnott mentioned this pull request Jan 16, 2024
Merged
AArnott pushed a commit that referenced this pull request Jan 16, 2024
@dependabot
Bump xunit from 2.6.2 to 2.6.3 (#239)
f8f3f9e 
Bumps [xunit](https://github.com/xunit/xunit) from 2.6.2 to 2.6.3.
- [Commits](xunit/xunit@2.6.2...2.6.3)

---
updated-dependencies:
- dependency-name: xunit
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@AArnott AArnott mentioned this pull request Mar 31, 2024
Merged
@AArnott AArnott mentioned this pull request Jul 19, 2024
Merged
@AArnott AArnott mentioned this pull request Oct 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reniris @neuecc
Morty Proxy This is a proxified and sanitized view of the page, visit original site.