Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix mis-fire of MsgPack003 on use of Collection<T> #2037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

AArnott
Copy link
Collaborator

@AArnott AArnott commented Oct 23, 2024

Fixes #2035

@AArnott AArnott requested a review from neuecc October 23, 2024 14:28
@AArnott AArnott added this to the v3.0 milestone Oct 23, 2024
@AArnott
Copy link
Collaborator Author

AArnott commented Oct 23, 2024

@neuecc Is this the best fix? As the original issue states, the runtime was fine. It was just the analyzer. So do we really need a new concrete class to handle this type (for native AOT perhaps?) or is there a better way to suppress the analyzer (e.g. by recognizing that it implements IList<T> and fits some pattern than an existing formatter/resolver can handle)?

@AArnott
Copy link
Collaborator Author

AArnott commented Oct 25, 2024

I'm pretty sure this just creates a redundant formatter, and still leaves a gaping hole between what the analyzer detects and what the DynamicGenericResolver is willing to do at runtime. I'm working on a real fix.

@AArnott AArnott merged commit 15caf64 into develop Oct 25, 2024
6 checks passed
@AArnott AArnott deleted the fix2035 branch October 25, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
Morty Proxy This is a proxified and sanitized view of the page, visit original site.