Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix embedded types being generated in resolver #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2024
Merged

Fix embedded types being generated in resolver #2000

merged 1 commit into from
Oct 15, 2024

Conversation

AlanLiu90
Copy link
Contributor

The result of FormattableType.Name.Name is different from ITypeSymbol.ToString:

ITypeSymbol.ToString FormattableType.Name.Name
int int Int32
System.DateTime System.DateTime DateTime

It causes the branch handling embedded types becomes useless.

@AArnott AArnott added this to the v3.0 milestone Oct 14, 2024
AArnott
AArnott approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AArnott AArnott merged commit 85c44d6 into MessagePack-CSharp:develop Oct 15, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AArnott AArnott AArnott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AlanLiu90 @AArnott
Morty Proxy This is a proxified and sanitized view of the page, visit original site.