Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Reconcile AllowPrivate behavior #1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 8, 2024
Merged

Reconcile AllowPrivate behavior #1990

merged 5 commits into from
Oct 8, 2024

Conversation

AArnott
Copy link
Collaborator

@AArnott AArnott commented Oct 8, 2024

Report MsgPack004 on non-public members only after an attribute appears on a non-public member

Also report MsgPack011 only when a private member is to be serialized.

Add MessagePackObjectAttribute.AllowPrivate property

Update DynamicObjectResolver

  • to honor the new attribute property. This means that types that require private members to be serialized no longer must ask the application to use DynamicObjectResolverAllowPrivate, because the attribute will switch the ordinary resolver into AllowPrivate mode for that particular type.

Update the source generated formatters:

  • to not require partial types for serializing protected internal members.
  • to only serialize public members in map mode, or all members when the new attribute property is true.

Update the analyzer code fix provider

  • to require non-public members to be attributed when the new attribute property is set to true.

Update tests

  • several new tests added
  • map mode tests that used internal were changed either to public or to use the new attribute property (somewhat arbitrarily) in order to keep the tests passing.

Fix missing analyzer docs

Add MsgPack015 analyzer to encourage use of new AllowPrivate property

While source generators don't require it, it makes a real difference when using DynamicObjectResolver (which is the default, when a source generated formatter isn't found).

This analyzer comes with a code fix provider.

Plenty of tests (mostly testing source generated formatters) were using internal rather than public so with the analyzer enabled, a lot of test fixes were required.

Closes #1899

…rs on a non-public member

Also report MsgPack011 only when a private member is to be serialized.
Update `DynamicObjectResolver`
- to honor the new attribute property. This means that types that require private members to be serialized no longer must ask the application to use `DynamicObjectResolverAllowPrivate`, because the attribute will switch the ordinary resolver into AllowPrivate mode for that particular type.

Update the source generated formatters:
- to not require partial types for serializing `protected internal` members.
- to only serialize public members in map mode, or all members when the new attribute property is `true`.

Update the analyzer code fix provider
- to require non-public members to be attributed when the new attribute property is set to `true`.

Update tests
- several new tests added
- map mode tests that used `internal` were changed either to `public` or to use the new attribute property (somewhat arbitrarily) in order to keep the tests passing.
While source generators don't require it, it makes a real difference when using `DynamicObjectResolver` (which is the default, when a source generated formatter isn't found).

This analyzer comes with a code fix provider.

Plenty of tests (mostly testing source generated formatters) were using `internal` rather than `public` so with the analyzer enabled, a lot of test fixes were required.
@AArnott AArnott merged commit 040115a into develop Oct 8, 2024
5 checks passed
@AArnott AArnott deleted the fix1899 branch October 8, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
Morty Proxy This is a proxified and sanitized view of the page, visit original site.