Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Replace DynamicMethod use with private-capable Ref.Emit #1981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Conversation

AArnott
Copy link
Collaborator

@AArnott AArnott commented Oct 3, 2024

Closes #1979

@AArnott AArnott added this to the v3.0 milestone Oct 3, 2024
@AArnott AArnott requested a review from neuecc October 3, 2024 18:24
Copy link
Member

@neuecc neuecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you.
By the way, not just for NETFRAMEWORK, but has AssemblyBuilder.Save become possible in .NET 9?
dotnet/runtime#83988
I often used to check the contents with ILSpy, so it would be great if this makes it easier to verify.

@AArnott
Copy link
Collaborator Author

AArnott commented Oct 7, 2024

By the way, not just for NETFRAMEWORK, but has AssemblyBuilder.Save become possible in .NET 9?

I'm looking forward to that myself. Can't enable it yet because we don't target .NET 9. But doing that makes sense in November when .NET 9 hits GA (and .NET 6 falls out of support).

@AArnott AArnott merged commit 53734dc into develop Oct 7, 2024
5 checks passed
@AArnott AArnott deleted the fix1979 branch October 7, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.