You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: For records with a primary constructor we do not generate a code fix at the moment, since we can not specify the target of the generated attribute (since AttributeSyntax.WithTarget is missing).
Ooh, I have another request for you. This change doesn't merge cleanly with develop, which has a lot of changes because we're totally reworking the analyzer to include a source generator. I'd like to get this fixed in develop as well (assuming the bug also repros there) so that your fix carries forward to our v3 version.
After this PR merges, would you be willing to merge develop into your topic branch, resolve conflicts, and submit another PR to our develop branch?
Ooh, I have another request for you. This change doesn't merge cleanly with develop, which has a lot of changes because we're totally reworking the analyzer to include a source generator. I'd like to get this fixed in develop as well (assuming the bug also repros there) so that your fix carries forward to our v3 version. After this PR merges, would you be willing to merge develop into your topic branch, resolve conflicts, and submit another PR to our develop branch?
Will do later this week 👍 Thanks for 'primary constructor attributes'-fix.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1924
Added corresponding tests.
Note: For records with a primary constructor we do not generate a code fix at the moment, since we can not specify the target of the generated attribute (since AttributeSyntax.WithTarget is missing).