-
-
Notifications
You must be signed in to change notification settings - Fork 734
Faster multi-element serialization for primitive types #1872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster multi-element serialization for primitive types #1872
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the hardware accelerated code is beyond me. But I have a couple questions at least.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The product changes look good. How are we looking for test coverage? In particular, given the 16-element boundary that is interesting, it would seem prudent to have tests that cover lists of various sizes including at and around that 16-length boundary. Do we already have such tests, and are they running on .NET 8 such that they'll cover your new code?
No. There aren't, I think. |
There is an awful amount of noise in the failure logs, but there does appear to be a legitimate failure here. |
I've fixed bugs. I have a question about |
Given the length of the existing file, my vote is create a second file. |
Do you want me to merge this as-is, or do you want to add the deserialization optimization to it first? |
Ok. |
Rewrite of #1744