Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

.NET 8 Update(4): System.Collections.Frozen #1730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 12, 2024
Merged

.NET 8 Update(4): System.Collections.Frozen #1730

merged 4 commits into from
Jan 12, 2024

Conversation

pCYSl5EDgo
Copy link
Contributor

@pCYSl5EDgo pCYSl5EDgo commented Jan 11, 2024 •
edited
Loading

FrozenDictionary<TKey, TValue> and FrozenSet<T> are performant dictionary types for reading which were introduced in .NET 8.

This is for #1720

@pCYSl5EDgo pCYSl5EDgo mentioned this pull request Jan 11, 2024
Open
14 tasks
AArnott
AArnott requested changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Thank you!

src/MessagePack/Formatters/FrozenCollectionFormatters.cs Outdated Show resolved Hide resolved
src/MessagePack/Formatters/FrozenCollectionFormatters.cs Outdated Show resolved Hide resolved
src/MessagePack/Formatters/FrozenCollectionFormatters.cs Outdated Show resolved Hide resolved
src/MessagePack/Formatters/FrozenCollectionFormatters.cs Outdated Show resolved Hide resolved
AArnott
AArnott approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AArnott AArnott merged commit 6049d66 into MessagePack-CSharp:develop Jan 12, 2024
@AArnott AArnott added this to the v2.6 milestone Jan 12, 2024
@pCYSl5EDgo pCYSl5EDgo deleted the net8-Frozen branch January 12, 2024 19:02
@pCYSl5EDgo pCYSl5EDgo changed the title .Net 8 Update(4): System.Collections.Frozen .NET 8 Update(4): System.Collections.Frozen Jan 21, 2024
This was referenced Jan 27, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AArnott AArnott AArnott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pCYSl5EDgo @AArnott
Morty Proxy This is a proxified and sanitized view of the page, visit original site.