Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Avoid copying data twice in MessagePackWriter.MemoryCopy when running… #1607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AlanLiu90
Copy link
Contributor

@AlanLiu90 AlanLiu90 commented Apr 19, 2023

… in Unity

This PR uses UnsafeUtility.MemMove to implement MessagePackWriter.MemoryCopy in Unity. The API exists since Unity 2018.1, so all Unity versions supported by MessagePack have it.

@AArnott
Copy link
Collaborator

AArnott commented Apr 19, 2023

/azp run

@AlanLiu90
Copy link
Contributor Author

I saw there was a test failed, but it seems that it's unrelated to my PR. I tested on my local machine and all tests passed. I'm not sure about why it failed.

@AArnott AArnott added this to the v2.5 milestone Apr 19, 2023
@AArnott AArnott merged commit 620e41e into MessagePack-CSharp:master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.