Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Set nullable in unity #1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Y-YoL
Copy link
Contributor

@Y-YoL Y-YoL commented Apr 12, 2023

The only important part is "additionalCompilerArguments", but there are many differences because Unity automatically migrates

The only important part is "additionalCompilerArguments", but there are many differences because Unity automatically migrates
@AArnott
Copy link
Collaborator

AArnott commented Apr 12, 2023

Thanks. It looks like this exchanges one set of warnings for many others because it equally applies to all the .cs files, including those in projects that we haven't enabled nullable ref annotations on yet. Still, this seems like a step in the right direction.

@AArnott AArnott merged commit 7440007 into MessagePack-CSharp:sourceGenerator1495 Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.