Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 022c830

Browse filesBrowse files
BufoViridisMayaLekova
authored andcommitted
src: fix crypto.pbkdf2 callback error argument
Callbacks should always return `null` instead of `undefined` if no error occurred. PR-URL: nodejs#18458 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 6519373 commit 022c830
Copy full SHA for 022c830

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Collapse file

‎src/node_crypto.cc‎

Copy file name to clipboardExpand all lines: src/node_crypto.cc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4943,7 +4943,7 @@ void PBKDF2Request::Work(uv_work_t* work_req) {
49434943

49444944
void PBKDF2Request::After(Local<Value> (*argv)[2]) {
49454945
if (success_) {
4946-
(*argv)[0] = Undefined(env()->isolate());
4946+
(*argv)[0] = Null(env()->isolate());
49474947
(*argv)[1] = Buffer::New(env(), key_, keylen_).ToLocalChecked();
49484948
key_ = nullptr;
49494949
keylen_ = 0;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.