Update to stackpath domain #16
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution. I'm traveling this week, so probably won't be able to dig in to why the tests are failing until some time later in the following week. That said, I'd like to get this merged at some point. |
|
@kddeisz I understand closing this, and probably wouldn't have hit my radar again if you hadn't. I may still try to address this at some point. Cheers. |
Author
|
No worries! I ended up writing a ruby gem to do this since most of our code for it was in ruby anyway - it's here: https://github.com/localytics/stack_path if you want a reference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the previous endpoints no longer seem to work.